fix(nodetool): increase graceful stop timeout, handle and report `{badrpc, timeout}` error
This commit is contained in:
parent
f2346b2e9a
commit
9de9631d6b
|
@ -8,6 +8,8 @@
|
||||||
%% -------------------------------------------------------------------
|
%% -------------------------------------------------------------------
|
||||||
-mode(compile).
|
-mode(compile).
|
||||||
|
|
||||||
|
-define(SHUTDOWN_TIMEOUT_MS, 120_000).
|
||||||
|
|
||||||
main(Args) ->
|
main(Args) ->
|
||||||
case os:type() of
|
case os:type() of
|
||||||
{win32, nt} -> ok;
|
{win32, nt} -> ok;
|
||||||
|
@ -85,9 +87,14 @@ do(Args) ->
|
||||||
%% a "pong"
|
%% a "pong"
|
||||||
io:format("pong\n");
|
io:format("pong\n");
|
||||||
["stop"] ->
|
["stop"] ->
|
||||||
case rpc:call(TargetNode, emqx_machine, graceful_shutdown, [], 60000) of
|
case rpc:call(TargetNode, emqx_machine, graceful_shutdown, [], ?SHUTDOWN_TIMEOUT_MS) of
|
||||||
ok ->
|
ok ->
|
||||||
ok;
|
ok;
|
||||||
|
{badrpc, timeout} ->
|
||||||
|
io:format("EMQX is still shutting down, it failed to stop gracefully "
|
||||||
|
"within the configured timeout of: ~ps\n",
|
||||||
|
[erlang:convert_time_unit(?SHUTDOWN_TIMEOUT_MS, millisecond, second)]),
|
||||||
|
halt(1);
|
||||||
{badrpc, nodedown} ->
|
{badrpc, nodedown} ->
|
||||||
%% nodetool commands are always executed after a ping
|
%% nodetool commands are always executed after a ping
|
||||||
%% which if the code gets here, it's because the target node
|
%% which if the code gets here, it's because the target node
|
||||||
|
|
|
@ -0,0 +1,3 @@
|
||||||
|
Improve EMQX graceful shutdown (`emqx stop` command):
|
||||||
|
- increase timeout from 1 to 2 minutes
|
||||||
|
- print an error message if EMQX can't stop gracefully within the configured timeout
|
Loading…
Reference in New Issue