test(emqx_modules): do not expect badmatch in test cases!!!

apps/emqx_modules/src/emqx_modules.app.src

@@ -1,7 +1,7 @@
 %% -*- mode: erlang -*-
 {application, emqx_modules, [
     {description, "EMQX Modules"},
-    {vsn, "5.0.8"},
+    {vsn, "5.0.9"},
     {modules, []},
     {applications, [kernel, stdlib, emqx]},
     {mod, {emqx_modules_app, []}},

apps/emqx_modules/src/emqx_modules_schema.erl

@@ -88,8 +88,13 @@ regular_expression(_) -> undefined.
 
 is_re(Bin) ->
     case re:compile(Bin) of
-        {ok, _} -> ok;
+        {ok, _} ->
-        {error, Reason} -> {error, {Bin, Reason}}
+            ok;
+        {error, Reason} ->
+            {error, #{
+                regexp => Bin,
+                compile_error => Reason
+            }}
     end.
 
 array(Name, Meta) -> {Name, ?HOCON(?ARRAY(?R_REF(Name)), Meta)}.

apps/emqx_modules/src/emqx_rewrite.erl

@@ -67,8 +67,12 @@ list() ->
     emqx_conf:get_raw([<<"rewrite">>], []).
 
 update(Rules0) ->
-    {ok, _} = emqx_conf:update([rewrite], Rules0, #{override_to => cluster}),
+    case emqx_conf:update([rewrite], Rules0, #{override_to => cluster}) of
-    ok.
+        {ok, _} ->
+            ok;
+        {error, Reason} ->
+            throw(Reason)
+    end.
 
 post_config_update(_KeyPath, _Config, Rules, _OldConf, _AppEnvs) ->
     register_hook(Rules).

apps/emqx_modules/test/emqx_rewrite_SUITE.erl

@@ -215,16 +215,16 @@ t_update_re_failed(_Config) ->
             <<"action">> => <<"publish">>
         }
     ],
-    ?assertError(
+    ?assertThrow(
-        {badmatch,
-            {error,
-                {_, [
         #{
             kind := validation_error,
-                        reason := {Re, {"nothing to repeat", 0}},
+            path := "rewrite.1.re",
-                        value := Re
+            reason := #{
-                    }
+                regexp := <<"*^test/*">>,
-                ]}}},
+                compile_error := {"nothing to repeat", 0}
+            },
+            value := <<"*^test/*">>
+        },
         emqx_rewrite:update(Rules)
     ),
     ok.