diff --git a/apps/emqx/src/emqx_frame.erl b/apps/emqx/src/emqx_frame.erl index c7a09f874..c55c4d275 100644 --- a/apps/emqx/src/emqx_frame.erl +++ b/apps/emqx/src/emqx_frame.erl @@ -623,7 +623,6 @@ parse_binary_data(Bin) when parse_topic_name(Bin, false) -> parse_utf8_string(Bin, false); - parse_topic_name(Bin, true) -> case parse_utf8_string(Bin, true) of {<<>>, _Rest} -> ?PARSE_ERR(empty_topic_name); @@ -766,9 +765,9 @@ serialize_variable( ) -> [ serialize_utf8_string(TopicName), - if - PacketId =:= undefined -> <<>>; - true -> <> + case PacketId of + undefined -> <<>>; + _ -> <> end, serialize_properties(Properties, Ver) ];