yuanbiao
/
emqx
1
0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

chore: don't crash when add_handler failed

This commit is contained in:
Zhongwen Deng 2023-02-01 11:24:27 +08:00
parent 9cbad5297c
commit 95ef1e806c
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
apps/emqx/src/config/emqx_config_logger.erl
View File

@ -111,7 +111,17 @@ update_log_handler({Action, {handler, Id, Mod, Conf}}) ->
log_to_console("Config override: ~s is ~p~n", [id_for_log(Id), Action]), log_to_console("Config override: ~s is ~p~n", [id_for_log(Id), Action]),
% may return {error, {not_found, Id}} % may return {error, {not_found, Id}}
_ = logger:remove_handler(Id), _ = logger:remove_handler(Id),
ok = logger:add_handler(Id, Mod, Conf). case logger:add_handler(Id, Mod, Conf) of
ok ->
ok;
%% Don't crash here, otherwise the cluster rpc will retry the wrong handler forever.
{error, Reason} ->
log_to_console(
"Config override: ~s is ~p, but failed to add handler: ~p~n",
[id_for_log(Id), Action, Reason]
)
end,
ok.
id_for_log(console) -> "log.console_handler"; id_for_log(console) -> "log.console_handler";
id_for_log(Other) -> "log.file_handlers." ++ atom_to_list(Other). id_for_log(Other) -> "log.file_handlers." ++ atom_to_list(Other).