From 938d30268aff0534ceb474c60ff6f79e818bd093 Mon Sep 17 00:00:00 2001 From: tigercl Date: Thu, 20 Dec 2018 21:42:14 +0800 Subject: [PATCH] Remove extra case...of (#2082) * Remove extra case...of --- src/emqx_access_control.erl | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/src/emqx_access_control.erl b/src/emqx_access_control.erl index 2b9cb4211..239769de6 100644 --- a/src/emqx_access_control.erl +++ b/src/emqx_access_control.erl @@ -156,15 +156,13 @@ handle_call({register_mod, Type, Mod, Opts, Seq}, _From, State) -> reply(case lists:keymember(Mod, 1, Mods) of true -> {error, already_exists}; false -> - try - case Mod:init(Opts) of - {ok, ModState} -> - NewMods = lists:sort(fun({_, _, Seq1}, {_, _, Seq2}) -> - Seq1 >= Seq2 - end, [{Mod, ModState, Seq} | Mods]), - ets:insert(?TAB, {tab_key(Type), NewMods}), - ok - end + try Mod:init(Opts) of + {ok, ModState} -> + NewMods = lists:sort(fun({_, _, Seq1}, {_, _, Seq2}) -> + Seq1 >= Seq2 + end, [{Mod, ModState, Seq} | Mods]), + ets:insert(?TAB, {tab_key(Type), NewMods}), + ok catch _:Error -> emqx_logger:error("[AccessControl] Failed to init ~s: ~p", [Mod, Error]),