diff --git a/src/emqx_protocol.erl b/src/emqx_protocol.erl index d981309e4..e3ce36bd5 100644 --- a/src/emqx_protocol.erl +++ b/src/emqx_protocol.erl @@ -631,14 +631,14 @@ set_session_attrs({max_inflight, #pstate{zone = Zone, proto_ver = ProtoVer, conn maps:put(max_inflight, if ProtoVer =:= ?MQTT_PROTO_V5 -> get_property('Receive-Maximum', ConnProps, 65535); - true -> + true -> emqx_zone:get_env(Zone, max_inflight, 65535) end, SessAttrs); set_session_attrs({expiry_interval, #pstate{zone = Zone, proto_ver = ProtoVer, conn_props = ConnProps, clean_start = CleanStart}}, SessAttrs) -> maps:put(expiry_interval, if ProtoVer =:= ?MQTT_PROTO_V5 -> get_property('Session-Expiry-Interval', ConnProps, 0); - true -> + true -> case CleanStart of true -> 0; false -> @@ -649,7 +649,7 @@ set_session_attrs({topic_alias_maximum, #pstate{zone = Zone, proto_ver = ProtoVe maps:put(topic_alias_maximum, if ProtoVer =:= ?MQTT_PROTO_V5 -> get_property('Topic-Alias-Maximum', ConnProps, 0); - true -> + true -> emqx_zone:get_env(Zone, max_topic_alias, 0) end, SessAttrs); set_session_attrs({_, #pstate{}}, SessAttrs) -> diff --git a/src/emqx_session.erl b/src/emqx_session.erl index 224b2be82..e123516e9 100644 --- a/src/emqx_session.erl +++ b/src/emqx_session.erl @@ -311,7 +311,7 @@ unsubscribe(SPid, PacketId, Properties, TopicFilters) -> UnsubReq = {PacketId, Properties, TopicFilters}, gen_server:cast(SPid, {unsubscribe, self(), UnsubReq}). --spec(resume(spid(), pid(), emqx:message()) -> ok). +-spec(resume(spid(), pid(), emqx:message() | undefined) -> ok). resume(SPid, ConnPid, WillMsg) -> gen_server:cast(SPid, {resume, ConnPid, WillMsg}). diff --git a/test/emqx_keepalive_SUITE.erl b/test/emqx_keepalive_SUITE.erl index 60472fd42..c4dbd80f2 100644 --- a/test/emqx_keepalive_SUITE.erl +++ b/test/emqx_keepalive_SUITE.erl @@ -26,7 +26,6 @@ groups() -> [{keepalive, [], [t_keepalive]}]. %%-------------------------------------------------------------------- t_keepalive(_) -> - {ok, _} = emqx_keepalive:start(fun() -> {ok, 1} end, 0, {keepalive, timeout}), {ok, KA} = emqx_keepalive:start(fun() -> {ok, 1} end, 1, {keepalive, timeout}), [resumed, timeout] = lists:reverse(keepalive_recv(KA, [])).