From 91180595d038a1d9931794f657985688ea0f4706 Mon Sep 17 00:00:00 2001 From: "Zaiming (Stone) Shi" Date: Sun, 13 Feb 2022 22:16:27 +0100 Subject: [PATCH] refactor(cli): simplify ACL cache CLI logging --- apps/emqx_management/src/emqx_mgmt_cli.erl | 18 ++++-------------- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/apps/emqx_management/src/emqx_mgmt_cli.erl b/apps/emqx_management/src/emqx_mgmt_cli.erl index 92dc4c578..7ca7a9cf6 100644 --- a/apps/emqx_management/src/emqx_mgmt_cli.erl +++ b/apps/emqx_management/src/emqx_mgmt_cli.erl @@ -577,21 +577,11 @@ data(_) -> %% @doc acl Command acl(["cache-clean", "node", Node]) -> - case for_node(fun emqx_mgmt:clean_acl_cache_all/1, Node) of - ok -> - emqx_ctl:print("ACL cache drain started on node ~s.~n", [Node]); - {error, Reason} -> - emqx_ctl:print("ACL drain failed on node ~s: ~0p.~n", [Node, Reason]) - end; - + with_log(fun() -> for_node(fun emqx_mgmt:clean_acl_cache_all/1, Node) end, + "ACL cache drain start"); acl(["cache-clean", "all"]) -> - case emqx_mgmt:clean_acl_cache_all() of - ok -> - emqx_ctl:print("Started ACL cache drain in all nodes~n"); - {error, Reason} -> - emqx_ctl:print("ACL cache-clean failed: ~p.~n", [Reason]) - end; - + with_log(fun emqx_mgmt:clean_acl_cache_all/1, + "ACL cache drain start"); acl(["cache-clean", ClientId]) -> emqx_mgmt:clean_acl_cache(ClientId);