yuanbiao
/
emqx
1
0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(paging): rename `partial` to `overflow` for clarity

This commit is contained in:
Andrew Mayorov 2023-01-12 19:25:40 +03:00
parent 9adc601754
commit 90e837783f
No known key found for this signature in database
GPG Key ID: 2837C62ACFBFED5D
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
apps/emqx_management/src/emqx_mgmt_api.erl
View File

@ -405,11 +405,11 @@ counting_total_fun(_QueryState = #{fuzzy_fun := FuzzyFun}) when FuzzyFun =/= und
%% ResultAcc :: #{count := integer(), %% ResultAcc :: #{count := integer(),
%% cursor := integer(), %% cursor := integer(),
%% rows := [{node(), Rows :: list()}], %% rows := [{node(), Rows :: list()}],
%% partial := boolean(), %% overflow := boolean(),
%% hasnext => boolean() %% hasnext => boolean()
%% } %% }
init_query_result() -> init_query_result() ->
#{cursor => 0, count => 0, rows => [], partial => false}. #{cursor => 0, count => 0, rows => [], overflow => false}.
accumulate_query_rows( accumulate_query_rows(
Node, Node,
@ -436,12 +436,13 @@ accumulate_query_rows(
cursor => NCursor, cursor => NCursor,
count => Count + length(SubRows), count => Count + length(SubRows),
rows => [{Node, SubRows} | RowsAcc], rows => [{Node, SubRows} | RowsAcc],
partial => (Limit - Count) < Len % there are more rows than can fit in the page
overflow => (Limit - Count) < Len
}} }}
end. end.
finalize_query(Result = #{partial := Partial}, QueryState = #{complete := Complete}) -> finalize_query(Result = #{overflow := Overflow}, QueryState = #{complete := Complete}) ->
HasNext = Partial orelse not Complete, HasNext = Overflow orelse not Complete,
maybe_accumulate_totals(Result#{hasnext => HasNext}, QueryState). maybe_accumulate_totals(Result#{hasnext => HasNext}, QueryState).
maybe_accumulate_totals(Result, #{total := TotalAcc}) -> maybe_accumulate_totals(Result, #{total := TotalAcc}) ->