From 8292572da62831b35efcdda501d023d3c54f0b9a Mon Sep 17 00:00:00 2001 From: JianBo He Date: Fri, 30 Sep 2022 23:02:28 +0800 Subject: [PATCH] chore: apply suggestions from code review Co-authored-by: Thales Macedo Garitezi --- apps/emqx_gateway/i18n/emqx_gateway_api_authn_i18n.conf | 2 +- apps/emqx_gateway/i18n/emqx_gateway_api_listeners_i18n.conf | 4 ++-- apps/emqx_gateway/src/emqx_gateway_api_listeners.erl | 2 +- apps/emqx_management/i18n/emqx_mgmt_api_banned_i18n.conf | 6 +++--- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/apps/emqx_gateway/i18n/emqx_gateway_api_authn_i18n.conf b/apps/emqx_gateway/i18n/emqx_gateway_api_authn_i18n.conf index c5886e8ba..c1f74e531 100644 --- a/apps/emqx_gateway/i18n/emqx_gateway_api_authn_i18n.conf +++ b/apps/emqx_gateway/i18n/emqx_gateway_api_authn_i18n.conf @@ -36,7 +36,7 @@ Note: Adding only one authenticator is supported in the gateway, rather than all list_users { desc { - en: """Get the users for the authenticator (only supports built_in_database).""" + en: """Get the users for the authenticator (only supported by built_in_database).""" zh: """获取用户列表（仅支持 built_in_database 类型的认证器）""" } } diff --git a/apps/emqx_gateway/i18n/emqx_gateway_api_listeners_i18n.conf b/apps/emqx_gateway/i18n/emqx_gateway_api_listeners_i18n.conf index 5567a2b5c..0b7c93afe 100644 --- a/apps/emqx_gateway/i18n/emqx_gateway_api_listeners_i18n.conf +++ b/apps/emqx_gateway/i18n/emqx_gateway_api_listeners_i18n.conf @@ -47,7 +47,7 @@ Note: For listener types not supported by a gateway, this API returns `400: BAD_ add_listener_authn { desc { en: """Enable authenticator for specified listener for client authentication.
-When authenticator is enabled for a listener, all clients connected to that listener will use that authenticator for authentication.""" +When authenticator is enabled for a listener, all clients connecting to that listener will use that authenticator for authentication.""" zh: """为指定监听器开启认证器以实现客户端认证的能力。
当某一监听器开启认证后，所有连接到该监听器的客户端会使用该认证器进行认证。""" } @@ -69,7 +69,7 @@ When authenticator is enabled for a listener, all clients connected to that list list_users { desc { - en: """Get the users for the authenticator (only supports built_in_database)""" + en: """Get the users for the authenticator (only supported by built_in_database)""" zh: """获取用户列表（仅支持 built_in_database 类型的认证器）""" } } diff --git a/apps/emqx_gateway/src/emqx_gateway_api_listeners.erl b/apps/emqx_gateway/src/emqx_gateway_api_listeners.erl index a2d55edb9..259ca8b36 100644 --- a/apps/emqx_gateway/src/emqx_gateway_api_listeners.erl +++ b/apps/emqx_gateway/src/emqx_gateway_api_listeners.erl @@ -360,7 +360,7 @@ schema("/gateways/:name/listeners") -> #{ tags => [<<"Gateways">>], desc => ?DESC(list_listeners), - summary => <<"List All Listener">>, + summary => <<"List All Listeners">>, parameters => params_gateway_name_in_path(), responses => ?STANDARD_RESP( diff --git a/apps/emqx_management/i18n/emqx_mgmt_api_banned_i18n.conf b/apps/emqx_management/i18n/emqx_mgmt_api_banned_i18n.conf index 6bc736f9e..3045cb293 100644 --- a/apps/emqx_management/i18n/emqx_mgmt_api_banned_i18n.conf +++ b/apps/emqx_management/i18n/emqx_mgmt_api_banned_i18n.conf @@ -67,11 +67,11 @@ emqx_mgmt_api_banned { } reason { desc { - en: """Banned reason, record the reason why the current object was banned.""" + en: """Ban reason, record the reason why the current object was banned.""" zh: """封禁原因，记录当前对象被封禁的原因。""" } label { - en: """Banned Reason""" + en: """Ban Reason""" zh: """封禁原因""" } } @@ -87,7 +87,7 @@ emqx_mgmt_api_banned { } until { desc { - en: """The end time of the ban, the formula is rfc3339, the default is the time when the operation was initiated + 5 minutes.""" + en: """The end time of the ban, the format is rfc3339, the default is the time when the operation was initiated + 5 minutes.""" zh: """封禁的结束时间，式为 rfc3339，默认为发起操作的时间 + 5 分钟。""" } label {