From 7f18969f1e8445d50b5a948498f5c1b3a4db1333 Mon Sep 17 00:00:00 2001
From: firest <blankalupo@163.com>
Date: Thu, 30 Jun 2022 14:58:09 +0800
Subject: [PATCH] fix(metrics): revert client.authenticate count method

---
 apps/emqx/src/emqx_access_control.erl | 2 +-
 apps/emqx/src/emqx_authentication.erl | 8 ++------
 2 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/apps/emqx/src/emqx_access_control.erl b/apps/emqx/src/emqx_access_control.erl
index 37770e443..1b864cda9 100644
--- a/apps/emqx/src/emqx_access_control.erl
+++ b/apps/emqx/src/emqx_access_control.erl
@@ -34,7 +34,7 @@
     | {continue, binary(), map()}
     | {error, term()}.
 authenticate(Credential) ->
-    case emqx_hooks:run_fold('client.authenticate', [Credential], {ok, #{is_superuser => false}}) of
+    case run_hooks('client.authenticate', [Credential], {ok, #{is_superuser => false}}) of
         ok ->
             {ok, #{is_superuser => false}};
         Other ->
diff --git a/apps/emqx/src/emqx_authentication.erl b/apps/emqx/src/emqx_authentication.erl
index e6caf9b26..4cf2c99cd 100644
--- a/apps/emqx/src/emqx_authentication.erl
+++ b/apps/emqx/src/emqx_authentication.erl
@@ -909,12 +909,8 @@ to_list(L) when is_list(L) -> L.
 
 call(Call) -> gen_server:call(?MODULE, Call, infinity).
 
-inc_authenticate_metric(Metric) ->
-    emqx_metrics:inc('client.authenticate'),
-    inc_authenticate_metric2(Metric).
-
-inc_authenticate_metric2('authentication.success.anonymous' = Metric) ->
+inc_authenticate_metric('authentication.success.anonymous' = Metric) ->
     emqx_metrics:inc(Metric),
     emqx_metrics:inc('authentication.success');
-inc_authenticate_metric2(Metric) ->
+inc_authenticate_metric(Metric) ->
     emqx_metrics:inc(Metric).