fix: deny POST an existing resource

apps/emqx_rule_engine/src/emqx_rule_engine_api.erl

@@ -315,6 +315,16 @@ create_resource(#{}, Params) ->
     end.
 
 do_create_resource(Create, ParsedParams) ->
+    case maps:find(id, ParsedParams) of
+        {ok, ResId} ->
+            case emqx_rule_registry:find_resource(ResId) of
+                {ok, _} -> return({error, 400, <<"Already Exists">>});
+                not_found -> do_create_resource2(Create, ParsedParams)
+            end;
+        error -> do_create_resource2(Create, ParsedParams)
+    end.
+
+do_create_resource2(Create, ParsedParams) ->
     case emqx_rule_engine:Create(ParsedParams) of
         ok ->
             return(ok);

apps/emqx_rule_engine/test/emqx_rule_engine_SUITE.erl

@@ -600,13 +600,18 @@ t_show_action_api(_Config) ->
     ok.
 
 t_crud_resources_api(_Config) ->
-    {ok, #{code := 0, data := Resources1}} =
+    ResParams = [
-        emqx_rule_engine_api:create_resource(#{},
+        {<<"name">>, <<"Simple Resource">>},
-            [{<<"name">>, <<"Simple Resource">>},
         {<<"type">>, <<"built_in">>},
         {<<"config">>, [{<<"a">>, 1}]},
-             {<<"description">>, <<"Simple Resource">>}]),
+        {<<"description">>, <<"Simple Resource">>}
+    ],
+    {ok, #{code := 0, data := Resources1}} =
+        emqx_rule_engine_api:create_resource(#{}, ResParams),
     ResId = maps:get(id, Resources1),
+    %% create again using given resource id returns error
+    {ok, #{code := 400, message := <<"Already Exists">>}} =
+        emqx_rule_engine_api:create_resource(#{}, [{<<"id">>, ResId} | ResParams]),
     {ok, #{code := 0, data := Resources}} = emqx_rule_engine_api:list_resources(#{}, []),
     ?assert(length(Resources) > 0),
     {ok, #{code := 0, data := Resources2}} = emqx_rule_engine_api:show_resource(#{id => ResId}, []),