yuanbiao
/
emqx
1
0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

chore(route-sync): clarify why wait indefinitely for reply

This commit is contained in:
Andrew Mayorov 2024-01-10 19:08:23 +01:00
parent 498b7a922d
commit 7d037cfe91
No known key found for this signature in database
GPG Key ID: 2837C62ACFBFED5D
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
apps/emqx/src/emqx_router_syncer.erl
View File

@ -89,7 +89,14 @@ push(Action, Topic, Dest, Opts) ->
-spec wait(_WaitRef :: reference()) -> -spec wait(_WaitRef :: reference()) ->
ok | {error, _Reason}. ok | {error, _Reason}.
wait(MRef) -> wait(MRef) ->
%% FIXME: timeouts %% NOTE
%% No timeouts here because (as in `emqx_broker:call/2` case) callers do not
%% really expect this to fail with timeout exception. However, waiting
%% indefinitely is not the best option since it blocks the caller from receiving
%% other messages, so for instance channel (connection) process may not be able
%% to react to socket close event in time. Better option would probably be to
%% introduce cancellable operation, which will be able to check if the caller
%% would still be interested in the result.
receive receive
{MRef, Result} -> {MRef, Result} ->
Result Result