From 7472e531b174c2c01e61e6073bc694c2ed282d5e Mon Sep 17 00:00:00 2001
From: terry-xiaoyu <506895667@qq.com>
Date: Thu, 11 Jul 2019 11:40:09 +0800
Subject: [PATCH] Remove log handler for alarms

---
 src/emqx_app.erl                  |  2 --
 src/emqx_logger_handler.erl       | 43 -------------------------------
 test/emqx_alarm_handler_SUITE.erl | 20 +-------------
 3 files changed, 1 insertion(+), 64 deletions(-)
 delete mode 100644 src/emqx_logger_handler.erl

diff --git a/src/emqx_app.erl b/src/emqx_app.erl
index 8e8ce4c1b..f2c6b6dec 100644
--- a/src/emqx_app.erl
+++ b/src/emqx_app.erl
@@ -38,8 +38,6 @@ start(_Type, _Args) ->
     register(emqx, self()),
 
     emqx_alarm_handler:load(),
-    emqx_logger_handler:init(),
-
     print_vsn(),
     {ok, Sup}.
 
diff --git a/src/emqx_logger_handler.erl b/src/emqx_logger_handler.erl
deleted file mode 100644
index e0f5d9af4..000000000
--- a/src/emqx_logger_handler.erl
+++ /dev/null
@@ -1,43 +0,0 @@
-%% Copyright (c) 2013-2019 EMQ Technologies Co., Ltd. All Rights Reserved.
-%%
-%% Licensed under the Apache License, Version 2.0 (the "License");
-%% you may not use this file except in compliance with the License.
-%% You may obtain a copy of the License at
-%%
-%%     http://www.apache.org/licenses/LICENSE-2.0
-%%
-%% Unless required by applicable law or agreed to in writing, software
-%% distributed under the License is distributed on an "AS IS" BASIS,
-%% WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-%% See the License for the specific language governing permissions and
-%% limitations under the License.
-
--module(emqx_logger_handler).
-
--export([log/2]).
-
--export([init/0]).
-
-init() ->
-    logger:add_handler(emqx_logger_handler, 
-                       emqx_logger_handler, 
-                       #{level => error,
-                         filters => [{easy_filter, {fun filter_by_level/2, []}}],
-                         filters_default => stop}).
-
--spec log(LogEvent, Config) -> ok when LogEvent :: logger:log_event(), Config :: logger:handler_config().
-log(#{msg := {report, #{report := [{supervisor, SupName},
-                                   {errorContext, Error},
-                                   {reason, Reason},
-                                   {offender, _}]}}}, _Config) ->
-    alarm_handler:set_alarm({supervisor_report, [{supervisor, SupName},
-                                                 {errorContext, Error},
-                                                 {reason, Reason}]}),
-    ok;
-log(_LogEvent, _Config) ->
-    ok.
-
-filter_by_level(LogEvent = #{level := error}, _Extra) ->
-    LogEvent;
-filter_by_level(_LogEvent, _Extra) ->
-    stop.
diff --git a/test/emqx_alarm_handler_SUITE.erl b/test/emqx_alarm_handler_SUITE.erl
index c918ce4a7..f6aba8a1f 100644
--- a/test/emqx_alarm_handler_SUITE.erl
+++ b/test/emqx_alarm_handler_SUITE.erl
@@ -24,8 +24,7 @@
 -include("emqx_mqtt.hrl").
 -include("emqx.hrl").
 
-all() -> [t_alarm_handler,
-          t_logger_handler].
+all() -> [t_alarm_handler].
 
 init_per_suite(Config) ->
     emqx_ct_helpers:start_apps([], fun set_special_configs/1),
@@ -97,23 +96,6 @@ t_alarm_handler(_) ->
 
         end).
 
-t_logger_handler(_) ->
-    %% Meck supervisor report
-    logger:log(error, #{label => {supervisor, start_error},
-                        report => [{supervisor, {local, tmp_sup}},
-                                   {errorContext, shutdown},
-                                   {reason, reached_max_restart_intensity},
-                                   {offender, [{pid, meck},
-                                               {id, meck},
-                                               {mfargs, {meck, start_link, []}},
-                                               {restart_type, permanent},
-                                               {shutdown, 5000},
-                                               {child_type, worker}]}]},
-               #{logger_formatter => #{title => "SUPERVISOR REPORT"},
-                 report_cb => fun logger:format_otp_report/1}),
-    timer:sleep(20),
-    ?assertEqual(true, lists:keymember(supervisor_report, 1, emqx_alarm_handler:get_alarms())).
-
 raw_send_serialize(Packet) ->
     emqx_frame:serialize(Packet).