From 9311080f0bdbf5c6cd9182ae89b180da63be8844 Mon Sep 17 00:00:00 2001
From: EMQ-YangM <yangm@emqx.io>
Date: Sun, 24 Apr 2022 15:57:04 +0800
Subject: [PATCH] fix: avoid '/connectors' function pattern matching failures

---
 apps/emqx_connector/src/emqx_connector_api.erl        | 5 ++++-
 apps/emqx_connector/test/emqx_connector_api_SUITE.erl | 5 +++++
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/apps/emqx_connector/src/emqx_connector_api.erl b/apps/emqx_connector/src/emqx_connector_api.erl
index c49860d49..4aa710c79 100644
--- a/apps/emqx_connector/src/emqx_connector_api.erl
+++ b/apps/emqx_connector/src/emqx_connector_api.erl
@@ -223,7 +223,10 @@ schema("/connectors/:id") ->
                 {error, Error} ->
                     {400, error_msg('BAD_REQUEST', Error)}
             end
-    end.
+    end;
+
+'/connectors'(post, _) ->
+    {400, error_msg('BAD_REQUEST', <<"missing some required fields: [name, type]">>)}.
 
 '/connectors/:id'(get, #{bindings := #{id := Id}}) ->
     ?TRY_PARSE_ID(Id,
diff --git a/apps/emqx_connector/test/emqx_connector_api_SUITE.erl b/apps/emqx_connector/test/emqx_connector_api_SUITE.erl
index 9291af624..329bfe059 100644
--- a/apps/emqx_connector/test/emqx_connector_api_SUITE.erl
+++ b/apps/emqx_connector/test/emqx_connector_api_SUITE.erl
@@ -137,6 +137,11 @@ t_mqtt_crud_apis(_) ->
     %% then we add a mqtt connector, using POST
     %% POST /connectors/ will create a connector
     User1 = <<"user1">>,
+    {ok, 400, <<"{\"code\":\"BAD_REQUEST\",\"message\""
+                ":\"missing some required fields: [name, type]\"}">>}
+        = request(post, uri(["connectors"]),
+        ?MQTT_CONNECTOR(User1)#{ <<"type">> => ?CONNECTR_TYPE
+                               }),
     {ok, 201, Connector} = request(post, uri(["connectors"]),
         ?MQTT_CONNECTOR(User1)#{ <<"type">> => ?CONNECTR_TYPE
                                , <<"name">> => ?CONNECTR_NAME