From 73a8494760a6fb2dcff93e49c0e0086804235d86 Mon Sep 17 00:00:00 2001 From: Zaiming Shi Date: Wed, 17 Mar 2021 22:30:40 +0100 Subject: [PATCH] fix(build): rebar3 compile before release Doing release directly works fine for prue Erlang dependencies. However if we add a elixir dependency, the application info and release becomes problematic Elixir apps do not have .app or .app.src files so the app vsn can not be found during app discovery which leads to "No valid version ([]) of .app file found" error when creating the release. This is maybe fixed in https://github.com/erlang/rebar3/pull/2518 Another issue is "Undefined applications: [elixir,logger]" This seem to be caused by the rebar3 not being able to identify as a release dependency if an elixir app was not compiled before. --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index cb36fcaec..85fd7bf6d 100644 --- a/Makefile +++ b/Makefile @@ -56,7 +56,7 @@ coveralls: $(REBAR) .PHONY: $(REL_PROFILES) $(REL_PROFILES:%=%): $(REBAR) get-dashboard - @$(REBAR) as $(@) release + @$(REBAR) as $(@) do compile,release ## Not calling rebar3 clean because ## 1. rebar3 clean relies on rebar3, meaning it reads config, fetches dependencies etc.