From 73655369afb34ca8895ab75c74c63cbedbc0b45d Mon Sep 17 00:00:00 2001 From: wwhai <751957846@qq.com> Date: Fri, 29 Jan 2021 11:28:38 +0800 Subject: [PATCH] fix(rule-engine): reformat some code --- apps/emqx_rule_engine/src/emqx_rule_engine_api.erl | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/apps/emqx_rule_engine/src/emqx_rule_engine_api.erl b/apps/emqx_rule_engine/src/emqx_rule_engine_api.erl index 1c391525f..3f13b64a3 100644 --- a/apps/emqx_rule_engine/src/emqx_rule_engine_api.erl +++ b/apps/emqx_rule_engine/src/emqx_rule_engine_api.erl @@ -334,7 +334,7 @@ update_resource(#{id := Id}, NewParams) -> end, P2 = case proplists:get_value(<<"config">>, NewParams) of undefined -> #{}; - <<"{}">> -> #{}; + [{}] -> #{}; Map -> #{<<"config">> => ?RAISE(maps:from_list(Map), {invalid_config, Map})} end, case emqx_rule_engine:update_resource(Id, maps:merge(P1, P2)) of @@ -342,13 +342,13 @@ update_resource(#{id := Id}, NewParams) -> return(ok); {error, not_found} -> ?LOG(error, "resource not found: ~0p", [Id]), - return({error, 400, list_to_binary("resource not found:" ++ binary_to_list(Id))}); + return({error, 400, <<"resource not found:", Id/binary>>}); {error, {init_resource_failure, _}} -> ?LOG(error, "init resource failure: ~0p", [Id]), - return({error, 500, list_to_binary("init resource failure:" ++ binary_to_list(Id))}); + return({error, 500, <<"init resource failure:", Id/binary>>}); {error, {dependency_exists, RuleId}} -> ?LOG(error, "dependency exists: ~0p", [RuleId]), - return({error, 500, list_to_binary("resource dependency by rule:" ++ binary_to_list(RuleId))}); + return({error, 500, <<"resource dependency by rule:", RuleId/binary>>}); {error, Reason} -> ?LOG(error, "update resource failed: ~0p", [Reason]), return({error, 500, <<"update resource failed,error info have been written to logfile!">>})