From 6efb07f6eb15db6391fc134e85ddaa2b5036dbef Mon Sep 17 00:00:00 2001 From: zhongwencool Date: Mon, 19 Jun 2023 18:12:33 +0800 Subject: [PATCH] fix: crash on emqx_ctl listeners --- apps/emqx_management/src/emqx_mgmt_cli.erl | 37 +++++++++++++--------- 1 file changed, 22 insertions(+), 15 deletions(-) diff --git a/apps/emqx_management/src/emqx_mgmt_cli.erl b/apps/emqx_management/src/emqx_mgmt_cli.erl index a3a643681..e0685b2ff 100644 --- a/apps/emqx_management/src/emqx_mgmt_cli.erl +++ b/apps/emqx_management/src/emqx_mgmt_cli.erl @@ -616,21 +616,28 @@ listeners([]) -> Acceptors = maps:get(acceptors, Conf), ProxyProtocol = maps:get(proxy_protocol, Conf, undefined), Running = maps:get(running, Conf), - CurrentConns = - case emqx_listeners:current_conns(ID, Bind) of - {error, _} -> []; - CC -> [{current_conn, CC}] - end, - MaxConn = - case emqx_listeners:max_conns(ID, Bind) of - {error, _} -> []; - MC -> [{max_conns, MC}] - end, - ShutdownCount = - case emqx_listeners:shutdown_count(ID, Bind) of - {error, _} -> []; - SC -> [{shutdown_count, SC}] - end, + case Running of + true -> + CurrentConns = + case emqx_listeners:current_conns(ID, Bind) of + {error, _} -> []; + CC -> [{current_conn, CC}] + end, + MaxConn = + case emqx_listeners:max_conns(ID, Bind) of + {error, _} -> []; + MC -> [{max_conns, MC}] + end, + ShutdownCount = + case emqx_listeners:shutdown_count(ID, Bind) of + {error, _} -> []; + SC -> [{shutdown_count, SC}] + end; + false -> + CurrentConns = [], + MaxConn = [], + ShutdownCount = [] + end, Info = [ {listen_on, {string, emqx_listeners:format_bind(Bind)}},