From 6d3add3646b3859a413c7f9e7b798a10e9ad6c24 Mon Sep 17 00:00:00 2001 From: Andrew Mayorov Date: Mon, 29 Apr 2024 15:23:57 +0200 Subject: [PATCH] fix(s3-aggreg): do not handle `{error, closed}` on buffer write Because it's not really something `file:write/2` is supposed to return. --- apps/emqx_bridge_s3/src/emqx_bridge_s3_aggregator.erl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/emqx_bridge_s3/src/emqx_bridge_s3_aggregator.erl b/apps/emqx_bridge_s3/src/emqx_bridge_s3_aggregator.erl index 9d1ac5575..47ecdeb4a 100644 --- a/apps/emqx_bridge_s3/src/emqx_bridge_s3_aggregator.erl +++ b/apps/emqx_bridge_s3/src/emqx_bridge_s3_aggregator.erl @@ -94,7 +94,7 @@ write_records(Name, Buffer = #buffer{fd = Writer}, Records) -> ok -> ?tp(s3_aggreg_records_written, #{action => Name, records => Records}), ok; - {error, Reason} when Reason == terminated orelse Reason == closed -> + {error, terminated} -> BufferNext = rotate_buffer(Name, Buffer), write_records(Name, BufferNext, Records); {error, _} = Error ->