From 6b2949e2c1ea1d2e9472027bc78f20e8ae211aac Mon Sep 17 00:00:00 2001
From: Zaiming Shi <zmstone@gmail.com>
Date: Tue, 2 Mar 2021 12:37:49 +0100
Subject: [PATCH] chore(config): Change default log_to config

By default log to file.
When start from console or forgreground, only log to console.
Only log to file for package builds.
---
 bin/emqx         | 9 ++++++++-
 etc/emqx.conf    | 2 +-
 priv/emqx.schema | 2 +-
 3 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/bin/emqx b/bin/emqx
index 81b1a9594..9aba13192 100755
--- a/bin/emqx
+++ b/bin/emqx
@@ -518,6 +518,9 @@ case "$1" in
                 ;;
         esac
 
+        # set before generate_config
+        export EMQX_LOG__TO='console'
+
         #generate app.config and vm.args
         generate_config
 
@@ -534,7 +537,8 @@ case "$1" in
         # shellcheck disable=SC2086 # $RELX_CONFIG_PATH $CONFIG_ARGS $EPMD_ARG are supposed to be split by whitespace
         # Build an array of arguments to pass to exec later on
         # Build it here because this command will be used for logging.
-        set -- "$BINDIR/erlexec" -boot "$BOOTFILE" -mode "$CODE_LOADING_MODE" \
+        set -- "$BINDIR/erlexec" \
+            -boot "$BOOTFILE" -mode "$CODE_LOADING_MODE" \
             -boot_var ERTS_LIB_DIR "$ERTS_LIB_DIR" \
             -mnesia dir "\"${MNESIA_DATA_DIR}\"" \
             $RELX_CONFIG_PATH $CONFIG_ARGS $EPMD_ARG
@@ -557,6 +561,9 @@ case "$1" in
         # start up the release in the foreground for use by runit
         # or other supervision services
 
+        # set before generate_config
+        export EMQX_LOG__TO='console'
+
         #generate app.config and vm.args
         generate_config
 
diff --git a/etc/emqx.conf b/etc/emqx.conf
index ddc17eef9..672ce8556 100644
--- a/etc/emqx.conf
+++ b/etc/emqx.conf
@@ -412,7 +412,7 @@ rpc.socket_buffer = 1MB
 ## - file: write logs only to file
 ## - console: write logs only to standard I/O
 ## - both: write logs both to file and standard I/O
-log.to = both
+log.to = file
 
 ## The log severity level.
 ##
diff --git a/priv/emqx.schema b/priv/emqx.schema
index fa9cf1efb..0e933c44f 100644
--- a/priv/emqx.schema
+++ b/priv/emqx.schema
@@ -449,7 +449,7 @@ end}.
 %%--------------------------------------------------------------------
 
 {mapping, "log.to", "kernel.logger", [
-  {default, console},
+  {default, file},
   {datatype, {enum, [off, file, console, both]}}
 ]}.