chore: fix duplicated variable name

apps/emqx_auth_http/src/emqx_acl_http.erl

@@ -56,14 +56,14 @@ description() -> "ACL with HTTP API".
 %% Internal functions
 %%--------------------------------------------------------------------
 
-check_acl_request(Params =
+check_acl_request(ACLParams =
                   #{pool_name := PoolName,
                     path := Path,
                     method := Method,
                     headers := Headers,
                     params := Params,
                     timeout := Timeout}, ClientInfo) ->
-    Retry = maps:get(retry_times, Params, ?DEFAULT_RETRY_TIMES),
+    Retry = maps:get(retry_times, ACLParams, ?DEFAULT_RETRY_TIMES),
     request(PoolName, Method, Path, Headers, feedvar(Params, ClientInfo), Timeout, Retry).
 
 access(subscribe) -> 1;

apps/emqx_auth_http/src/emqx_auth_http.app.src

@@ -1,6 +1,6 @@
 {application, emqx_auth_http,
  [{description, "EMQ X Authentication/ACL with HTTP API"},
-  {vsn, "4.3.7"}, % strict semver, bump manually!
+  {vsn, "4.3.8"}, % strict semver, bump manually!
   {modules, []},
   {registered, [emqx_auth_http_sup]},
   {applications, [kernel,stdlib,ehttpc]},

apps/emqx_auth_http/src/emqx_auth_http.erl

@@ -63,27 +63,27 @@ description() -> "Authentication by HTTP API".
 %% Requests
 %%--------------------------------------------------------------------
 
-authenticate(Params =
+authenticate(AuthParams =
              #{pool_name := PoolName,
                path := Path,
                method := Method,
                headers := Headers,
                params := Params,
                timeout := Timeout}, ClientInfo) ->
-    Retry = maps:get(retry_times, Params, ?DEFAULT_RETRY_TIMES),
+    Retry = maps:get(retry_times, AuthParams, ?DEFAULT_RETRY_TIMES),
     request(PoolName, Method, Path, Headers, feedvar(Params, ClientInfo), Timeout, Retry).
 
 -spec(is_superuser(maybe(map()), emqx_types:client()) -> boolean()).
 is_superuser(undefined, _ClientInfo) ->
     false;
-is_superuser(Params =
+is_superuser(SuperParams =
              #{pool_name := PoolName,
                path := Path,
                method := Method,
                headers := Headers,
                params := Params,
                timeout := Timeout}, ClientInfo) ->
-    Retry = maps:get(retry_times, Params, ?DEFAULT_RETRY_TIMES),
+    Retry = maps:get(retry_times, SuperParams, ?DEFAULT_RETRY_TIMES),
     case request(PoolName, Method, Path, Headers, feedvar(Params, ClientInfo), Timeout, Retry) of
         {ok, 200, _Body}   -> true;
         {ok, _Code, _Body} -> false;

apps/emqx_auth_http/src/emqx_auth_http_cli.erl

@@ -29,7 +29,7 @@
 %%--------------------------------------------------------------------
 
 request(PoolName, Method, Path, Headers, Params, Timeout) ->
-    request(PoolName, Method, Path, Headers, Params, ?DEFAULT_RETRY_TIMES).
+    request(PoolName, Method, Path, Headers, Params, Timeout, ?DEFAULT_RETRY_TIMES).
 
 request(PoolName, get, Path, Headers, Params, Timeout, Retry) ->
     NewPath = Path ++ "?" ++ binary_to_list(cow_qs:qs(bin_kw(Params))),

apps/emqx_auth_mnesia/test/emqx_auth_mnesia_SUITE.erl

@@ -408,7 +408,7 @@ t_password_hash(_) ->
     ok = application:start(emqx_auth_mnesia).
 
 t_will_message_connection_denied(Config) when is_list(Config) ->
-    ClientId = Username = <<"subscriber">>,
+    ClientId = <<"subscriber">>,
     Password = <<"p">>,
     application:stop(emqx_auth_mnesia),
     ok = emqx_ct_helpers:start_apps([emqx_auth_mnesia]),