From 667da90e529f19a6e5d361d3b5707f5ad3881870 Mon Sep 17 00:00:00 2001
From: DDDHuang <44492639+DDDHuang@users.noreply.github.com>
Date: Thu, 28 Apr 2022 10:07:40 +0800
Subject: [PATCH] refactor: resource instance do_create_dry_run

---
 .../src/emqx_resource_instance.erl            | 19 ++++++++++++-------
 1 file changed, 12 insertions(+), 7 deletions(-)

diff --git a/apps/emqx_resource/src/emqx_resource_instance.erl b/apps/emqx_resource/src/emqx_resource_instance.erl
index 504afbe3d..bf197b88c 100644
--- a/apps/emqx_resource/src/emqx_resource_instance.erl
+++ b/apps/emqx_resource/src/emqx_resource_instance.erl
@@ -213,13 +213,18 @@ do_create_dry_run(ResourceType, Config) ->
     InstId = make_test_id(),
     case emqx_resource:call_start(InstId, ResourceType, Config) of
         {ok, ResourceState} ->
-            case emqx_resource:call_health_check(InstId, ResourceType, ResourceState) of
-                connected ->
-                    case emqx_resource:call_stop(InstId, ResourceType, ResourceState) of
-                        {error, _} = Error -> Error;
-                        _ -> ok
-                    end;
-                ConnectStatus -> {error, ConnectStatus}
+            Health =
+                case emqx_resource:call_health_check(InstId, ResourceType, ResourceState) of
+                    connected ->
+                        ok;
+                    {connected, _N} ->
+                        ok;
+                    ConnectStatus ->
+                        {error, ConnectStatus}
+                end,
+            case emqx_resource:call_stop(InstId, ResourceType, ResourceState) of
+                {error, _} = Error -> Error;
+                _ -> Health
             end;
         {error, Reason} ->
             {error, Reason}