From 5f74db6d88d93c2ecedee7c677318a548042bf1d Mon Sep 17 00:00:00 2001 From: Shawn <506895667@qq.com> Date: Mon, 18 Apr 2022 22:02:22 +0800 Subject: [PATCH] fix: treat all returns except {error, Reason} as ok --- apps/emqx_bridge/src/emqx_bridge.erl | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/apps/emqx_bridge/src/emqx_bridge.erl b/apps/emqx_bridge/src/emqx_bridge.erl index f9a3a6434..60cc94930 100644 --- a/apps/emqx_bridge/src/emqx_bridge.erl +++ b/apps/emqx_bridge/src/emqx_bridge.erl @@ -97,11 +97,12 @@ on_message_publish(Message = #message{topic = Topic, flags = Flags}) -> send_to_matched_egress_bridges(Topic, Msg) -> lists:foreach(fun (Id) -> try send_message(Id, Msg) of - ok -> ok; - Error -> ?SLOG(error, #{msg => "send_message_to_bridge_failed", - bridge => Id, error => Error}) + {error, Reason} -> + ?SLOG(error, #{msg => "send_message_to_bridge_failed", + bridge => Id, error => Reason}); + _ -> ok catch Err:Reason:ST -> - ?SLOG(error, #{msg => "send_message_to_bridge_crash", + ?SLOG(error, #{msg => "send_message_to_bridge_exception", bridge => Id, error => Err, reason => Reason, stacktrace => ST}) end