From 58db34ac62df5a8438a1ef4e518b0c8062a3ee94 Mon Sep 17 00:00:00 2001 From: Kjell Winblad Date: Thu, 12 Oct 2023 09:36:43 +0200 Subject: [PATCH] fix: apply suggestions from code review Co-authored-by: Zaiming (Stone) Shi --- apps/emqx_resource/src/emqx_resource.erl | 2 +- apps/emqx_resource/src/emqx_resource_manager.erl | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/apps/emqx_resource/src/emqx_resource.erl b/apps/emqx_resource/src/emqx_resource.erl index e66080c77..fea720a3c 100644 --- a/apps/emqx_resource/src/emqx_resource.erl +++ b/apps/emqx_resource/src/emqx_resource.erl @@ -535,7 +535,7 @@ call_channel_health_check(ResId, ChannelId, Mod, ResourceState) -> ?SAFE_CALL(Mod:on_get_channel_status(ResId, ChannelId, ResourceState)). call_add_channel(ResId, Mod, ResourceState, ChannelId, ChannelConfig) -> - %% Check if maybe_install_insert_template is exported + %% Check if on_add_channel is exported case erlang:function_exported(Mod, on_add_channel, 4) of true -> try diff --git a/apps/emqx_resource/src/emqx_resource_manager.erl b/apps/emqx_resource/src/emqx_resource_manager.erl index b914300cf..f8272f273 100644 --- a/apps/emqx_resource/src/emqx_resource_manager.erl +++ b/apps/emqx_resource/src/emqx_resource_manager.erl @@ -69,8 +69,8 @@ state, error, pid, - extra, - added_channels + added_channels, + extra }). -type data() :: #data{}.