From 57da71eb1d1fe230928f6fdb591e56903491f3bc Mon Sep 17 00:00:00 2001
From: Andrew Mayorov <encube.ul@gmail.com>
Date: Thu, 29 Jun 2023 19:04:03 +0200
Subject: [PATCH] perf(broker): avoid usorting aggregated routes in a loop

---
 apps/emqx/src/emqx_broker.erl | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/apps/emqx/src/emqx_broker.erl b/apps/emqx/src/emqx_broker.erl
index 1bbe4dc82..fef93768b 100644
--- a/apps/emqx/src/emqx_broker.erl
+++ b/apps/emqx/src/emqx_broker.erl
@@ -285,16 +285,16 @@ aggre([#route{topic = To, dest = Node}]) when is_atom(Node) ->
 aggre([#route{topic = To, dest = {Group, _Node}}]) ->
     [{To, Group}];
 aggre(Routes) ->
-    lists:foldl(
-        fun
-            (#route{topic = To, dest = Node}, Acc) when is_atom(Node) ->
-                [{To, Node} | Acc];
-            (#route{topic = To, dest = {Group, _Node}}, Acc) ->
-                lists:usort([{To, Group} | Acc])
-        end,
-        [],
-        Routes
-    ).
+    aggre(Routes, false, []).
+
+aggre([#route{topic = To, dest = Node} | Rest], Dedup, Acc) when is_atom(Node) ->
+    aggre(Rest, Dedup, [{To, Node} | Acc]);
+aggre([#route{topic = To, dest = {Group, _Node}} | Rest], _Dedup, Acc) ->
+    aggre(Rest, true, [{To, Group} | Acc]);
+aggre([], false, Acc) ->
+    Acc;
+aggre([], true, Acc) ->
+    lists:usort(Acc).
 
 %% @doc Forward message to another node.
 -spec forward(node(), emqx_types:topic(), emqx_types:delivery(), RpcMode :: sync | async) ->