From 560f415964c28fe9cf7ef35f9b980b794c49153c Mon Sep 17 00:00:00 2001 From: DDDHuang <44492639+DDDHuang@users.noreply.github.com> Date: Tue, 31 Aug 2021 19:27:08 +0800 Subject: [PATCH] fix: auto sub api doc & null body check (#5613) * fix: auto sub api doc & null body check --- apps/emqx_auto_subscribe/src/emqx_auto_subscribe_api.erl | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/apps/emqx_auto_subscribe/src/emqx_auto_subscribe_api.erl b/apps/emqx_auto_subscribe/src/emqx_auto_subscribe_api.erl index d55444dba..7eeef52ff 100644 --- a/apps/emqx_auto_subscribe/src/emqx_auto_subscribe_api.erl +++ b/apps/emqx_auto_subscribe/src/emqx_auto_subscribe_api.erl @@ -23,6 +23,7 @@ -export([auto_subscribe/2]). -define(EXCEED_LIMIT, 'EXCEED_LIMIT'). +-define(BAD_REQUEST, 'BAD_REQUEST'). api_spec() -> {[auto_subscribe_api()], []}. @@ -43,6 +44,8 @@ auto_subscribe_api() -> 'requestBody' => schema(), responses => #{ <<"200">> => schema(), + <<"400">> => emqx_mgmt_util:error_schema( + <<"Request body required">>, [?BAD_REQUEST]), <<"409">> => emqx_mgmt_util:error_schema( <<"Auto Subscribe topics max limit">>, [?EXCEED_LIMIT])}} }, @@ -53,6 +56,8 @@ auto_subscribe_api() -> auto_subscribe(get, _) -> {200, emqx_auto_subscribe:list()}; +auto_subscribe(put, #{body := #{}}) -> + {400, #{code => ?BAD_REQUEST, message => <<"Request body required">>}}; auto_subscribe(put, #{body := Params}) -> case emqx_auto_subscribe:update(Params) of {error, quota_exceeded} ->