From 5302459a36d7fe1f08a49ec0d9e70658fa348060 Mon Sep 17 00:00:00 2001
From: k32 <10274441+k32@users.noreply.github.com>
Date: Wed, 5 May 2021 11:30:58 +0200
Subject: [PATCH] fix(node_dump): Please shellcheck

---
 bin/node_dump | 21 +++++++++++----------
 1 file changed, 11 insertions(+), 10 deletions(-)

diff --git a/bin/node_dump b/bin/node_dump
index dc9ccae65..22eff8097 100755
--- a/bin/node_dump
+++ b/bin/node_dump
@@ -9,6 +9,8 @@ echo "Running node dump in ${ROOT_DIR}"
 cd "${ROOT_DIR}"
 
 DUMP="log/node_dump_$(date +"%Y%m%d_%H%M%S").tar.gz"
+CONF_DUMP="log/conf.dump"
+SYSINFO="log/sysinfo.txt"
 
 collect() {
     echo "========================================================"
@@ -32,22 +34,21 @@ collect() {
 
     collect bin/emqx_ctl vm all
     collect bin/emqx_ctl listeners
-} > log/sysinfo.txt
+} > "${SYSINFO}"
 
 {
     collect bin/emqx eval "'emqx_node_dump:app_env_dump()'"
-} > log/conf.dump
+} > "${CONF_DUMP}"
 
-# Collect log files that are not older than 3 days:
-LOGS=$(find log -mtime -3 \( -name '*.log.*' -or -name 'run_erl.log*' \))
-
-tar czf "${DUMP}" ${LOGS} \
-    log/sysinfo.txt \
-    log/conf.dump
+{
+    find log -mtime -3 \( -name '*.log.*' -or -name 'run_erl.log*' \)
+    echo "${SYSINFO}"
+    echo "${CONF_DUMP}"
+} | tar czf "${DUMP}" -T -
 
 ## Cleanup:
-rm log/sysinfo.txt
-#rm log/conf.dump # Keep it for inspection
+rm "${SYSINFO}"
+#rm "${CONF_DUMP}" # Keep it for inspection
 
 echo "Created a node dump ${DUMP}"
 echo -e "\nWARNING: this script tries to obfuscate secrets, but make sure to