yuanbiao
/
emqx
1
0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(emqx_rule_metrics): Fix type specs

This commit is contained in:
Zaiming Shi 2020-11-10 16:41:19 +01:00
parent a504539097
commit 526d6f74bb
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
apps/emqx_rule_engine/src/emqx_rule_metrics.erl
View File

@ -106,11 +106,11 @@
%%------------------------------------------------------------------------------ %%------------------------------------------------------------------------------
%% APIs %% APIs
%%------------------------------------------------------------------------------ %%------------------------------------------------------------------------------
-spec(create_rule_metrics(rule_id()) -> Ref :: reference()). -spec(create_rule_metrics(rule_id()) -> Ref :: counters:counters_ref()).
create_rule_metrics(Id) -> create_rule_metrics(Id) ->
gen_server:call(?MODULE, {create_rule_metrics, Id}). gen_server:call(?MODULE, {create_rule_metrics, Id}).
-spec(create_metrics(rule_id()) -> Ref :: reference()). -spec(create_metrics(rule_id()) -> Ref :: counters:counters_ref()).
create_metrics(Id) -> create_metrics(Id) ->
gen_server:call(?MODULE, {create_metrics, Id}). gen_server:call(?MODULE, {create_metrics, Id}).
@ -133,7 +133,7 @@ get(Id, Metric) ->
get_overall(Metric) -> get_overall(Metric) ->
emqx_metrics:val(Metric). emqx_metrics:val(Metric).
-spec(get_rule_speed(atom()) -> map()). -spec(get_rule_speed(rule_id()) -> map()).
get_rule_speed(Id) -> get_rule_speed(Id) ->
gen_server:call(?MODULE, {get_rule_speed, Id}). gen_server:call(?MODULE, {get_rule_speed, Id}).
@ -157,14 +157,16 @@ get_action_metrics(Id) ->
taken => get_actions_taken(Id) taken => get_actions_taken(Id)
}. }.
-spec(inc(rule_id(), atom()) -> ok). -spec inc(rule_id(), atom()) -> ok.
inc(Id, Metric) -> inc(Id, Metric) ->
inc(Id, Metric, 1). inc(Id, Metric, 1).
-spec inc(rule_id(), atom(), pos_integer()) -> ok.
inc(Id, Metric, Val) -> inc(Id, Metric, Val) ->
counters:add(couters_ref(Id), metrics_idx(Metric), Val), counters:add(couters_ref(Id), metrics_idx(Metric), Val),
inc_overall(Metric, Val). inc_overall(Metric, Val).
-spec(inc_overall(rule_id(), atom()) -> ok). -spec(inc_overall(atom(), pos_integer()) -> ok).
inc_overall(Metric, Val) -> inc_overall(Metric, Val) ->
emqx_metrics:inc(Metric, Val). emqx_metrics:inc(Metric, Val).