From 7ed13846232dbd80f1a7f76f722ee06b0a63cd31 Mon Sep 17 00:00:00 2001
From: Shawn <506895667@qq.com>
Date: Mon, 9 Jan 2023 16:02:10 +0800
Subject: [PATCH 1/3] fix: missing default value for qos field of API
 /clients/:clientid/subscribe

---
 apps/emqx_management/src/emqx_mgmt_api_clients.erl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/apps/emqx_management/src/emqx_mgmt_api_clients.erl b/apps/emqx_management/src/emqx_mgmt_api_clients.erl
index 8eb4b26e9..539f38c6c 100644
--- a/apps/emqx_management/src/emqx_mgmt_api_clients.erl
+++ b/apps/emqx_management/src/emqx_mgmt_api_clients.erl
@@ -550,7 +550,7 @@ fields(keepalive) ->
 fields(subscribe) ->
     [
         {topic, hoconsc:mk(binary(), #{desc => <<"Topic">>})},
-        {qos, hoconsc:mk(emqx_schema:qos(), #{desc => <<"QoS">>})},
+        {qos, hoconsc:mk(emqx_schema:qos(), #{default => 0, desc => <<"QoS">>})},
         {nl, hoconsc:mk(integer(), #{default => 0, desc => <<"No Local">>})},
         {rap, hoconsc:mk(integer(), #{default => 0, desc => <<"Retain as Published">>})},
         {rh, hoconsc:mk(integer(), #{default => 0, desc => <<"Retain Handling">>})}

From e88529d55b92d80b14d888fc339083702c43663a Mon Sep 17 00:00:00 2001
From: Shawn <506895667@qq.com>
Date: Mon, 9 Jan 2023 16:12:45 +0800
Subject: [PATCH 2/3] chore: update change logs for #9703

---
 changes/v5.0.14/fix-9703.en.md | 3 +++
 changes/v5.0.14/fix-9703.zh.md | 2 ++
 2 files changed, 5 insertions(+)
 create mode 100644 changes/v5.0.14/fix-9703.en.md
 create mode 100644 changes/v5.0.14/fix-9703.zh.md

diff --git a/changes/v5.0.14/fix-9703.en.md b/changes/v5.0.14/fix-9703.en.md
new file mode 100644
index 000000000..4eb91c7d0
--- /dev/null
+++ b/changes/v5.0.14/fix-9703.en.md
@@ -0,0 +1,3 @@
+Set the default value of the `qos` field of the HTTP API `/clients/:clientid/subscribe` to 0.
+Before this fix, the `qos` field have no default value, which leads to a `function_clause` error
+when querying this API.
diff --git a/changes/v5.0.14/fix-9703.zh.md b/changes/v5.0.14/fix-9703.zh.md
new file mode 100644
index 000000000..863304a66
--- /dev/null
+++ b/changes/v5.0.14/fix-9703.zh.md
@@ -0,0 +1,2 @@
+将 HTTP 接口 `/clients/:clientid/subscribe` 的 `qos` 字段的默认值设置为 0。
+在此修复之前，`qos` 字段没有默认值，调用订阅接口的时候将导致 `function_clause` 错误。

From 50717a556717fc20c3e57e91947421a402411159 Mon Sep 17 00:00:00 2001
From: Shawn <506895667@qq.com>
Date: Mon, 9 Jan 2023 17:57:39 +0800
Subject: [PATCH 3/3] fix: set the topic field of API
 /clients/:clientid/subscribe as requried

---
 apps/emqx_management/src/emqx_mgmt_api_clients.erl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/apps/emqx_management/src/emqx_mgmt_api_clients.erl b/apps/emqx_management/src/emqx_mgmt_api_clients.erl
index 539f38c6c..f078f4d2a 100644
--- a/apps/emqx_management/src/emqx_mgmt_api_clients.erl
+++ b/apps/emqx_management/src/emqx_mgmt_api_clients.erl
@@ -549,7 +549,7 @@ fields(keepalive) ->
     ];
 fields(subscribe) ->
     [
-        {topic, hoconsc:mk(binary(), #{desc => <<"Topic">>})},
+        {topic, hoconsc:mk(binary(), #{required => true, desc => <<"Topic">>})},
         {qos, hoconsc:mk(emqx_schema:qos(), #{default => 0, desc => <<"QoS">>})},
         {nl, hoconsc:mk(integer(), #{default => 0, desc => <<"No Local">>})},
         {rap, hoconsc:mk(integer(), #{default => 0, desc => <<"Retain as Published">>})},