yuanbiao
/
emqx
1
0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(connector): fix previous incorrectly fixes 

There was an error in the try_clear_certs2/3 clause that the argument isn't the ssl field but including it.
This commit is contained in:
firest 2022-11-30 21:36:43 +08:00
parent 5a2265a286
commit 51ace31f30
1 changed files with 9 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
apps/emqx_connector/src/emqx_connector_ssl.erl
View File

@ -70,14 +70,11 @@ try_clear_certs(RltvDir, NewConf, OldConf) ->
). ).
try_clear_certs2(RltvDir, #{<<"connector">> := NewConnector}, #{<<"connector">> := OldConnector}) -> try_clear_certs2(RltvDir, #{<<"connector">> := NewConnector}, #{<<"connector">> := OldConnector}) ->
NewSSL = maps:get(<<"ssl">>, NewConnector, undefined), try_clear_certs2(RltvDir, NewConnector, OldConnector);
OldSSL = maps:get(<<"ssl">>, OldConnector, undefined),
try_clear_certs2(RltvDir, NewSSL, OldSSL);
try_clear_certs2(RltvDir, NewSSL, OldSSL) when is_map(NewSSL) andalso is_map(OldSSL) ->
ok = emqx_tls_lib:delete_ssl_files(RltvDir, NewSSL, OldSSL);
try_clear_certs2(RltvDir, NewConf, OldConf) -> try_clear_certs2(RltvDir, NewConf, OldConf) ->
?SLOG(debug, #{msg => "unexpected_conf", path => RltvDir, new => NewConf, OldConf => OldConf}), NewSSL = try_map_get(<<"ssl">>, NewConf, undefined),
ok. OldSSL = try_map_get(<<"ssl">>, OldConf, undefined),
ok = emqx_tls_lib:delete_ssl_files(RltvDir, NewSSL, OldSSL).
new_ssl_config(RltvDir, Config, SSL) -> new_ssl_config(RltvDir, Config, SSL) ->
case emqx_tls_lib:ensure_ssl_files(RltvDir, SSL) of case emqx_tls_lib:ensure_ssl_files(RltvDir, SSL) of
@ -100,3 +97,8 @@ new_ssl_config(Config, _NewSSL) ->
normalize_key_to_bin(Map) -> normalize_key_to_bin(Map) ->
emqx_map_lib:binary_key_map(Map). emqx_map_lib:binary_key_map(Map).
try_map_get(Key, Map, Default) when is_map(Map) ->
maps:get(Key, Map, Default);
try_map_get(_Key, undefined, Default) ->
Default.