yuanbiao
/
emqx
1
0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

chore: skip signing macos binaries when dev cert of pw are not set

This commit is contained in:
Ivan Dyachkov 2022-09-15 10:27:09 +02:00
parent 25b29de821
commit 501667dc1f
2 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
build
View File

@ -253,13 +253,23 @@ make_tgz() {
cp_dyn_libs "${tard}/emqx" cp_dyn_libs "${tard}/emqx"
case "$SYSTEM" in case "$SYSTEM" in
macos*) macos*)
# if the flag to sign macos binaries is set, but developer certificate
# or certificate password is not configured, reset the flag
# could happen, for example, when people submit PR from a fork, in this
# case they cannot access secrets
if [[ "${APPLE_SIGN_BINARIES:-0}" == 1 && \
( "${APPLE_DEVELOPER_ID_BUNDLE:-0}" == 0 || \
"${APPLE_DEVELOPER_ID_BUNDLE_PASSWORD:-0}" == 0 ) ]]; then
echo "Apple developer certificate is not configured, skip signing"
APPLE_SIGN_BINARIES=0
fi
if [ "${APPLE_SIGN_BINARIES:-0}" = 1 ]; then if [ "${APPLE_SIGN_BINARIES:-0}" = 1 ]; then
./scripts/macos-sign-binaries.sh "${tard}/emqx" ./scripts/macos-sign-binaries.sh "${tard}/emqx"
fi fi
## create zip after change dir ## create zip after change dir
## to avoid creating an extra level of 'emqx' dir in the .zip file ## to avoid creating an extra level of 'emqx' dir in the .zip file
pushd "${tard}/emqx" >/dev/null pushd "${tard}/emqx" >/dev/null
zip -r "../${target_name}" -- * zip -r "../${target_name}" -- * >/dev/null
popd >/dev/null popd >/dev/null
mv "${tard}/${target_name}" "${target}" mv "${tard}/${target_name}" "${target}"
if [ "${APPLE_SIGN_BINARIES:-0}" = 1 ]; then if [ "${APPLE_SIGN_BINARIES:-0}" = 1 ]; then

5
scripts/macos-sign-binaries.sh
View File

@ -12,6 +12,11 @@
set -euo pipefail set -euo pipefail
if [[ "${APPLE_DEVELOPER_ID_BUNDLE:-0}" == 0 || "${APPLE_DEVELOPER_ID_BUNDLE_PASSWORD:-0}" == 0 ]]; then
echo "Apple developer certificate is not configured, skip signing"
exit 0
fi
REL_DIR="${1}" REL_DIR="${1}"
PKSC12_FILE="$HOME/developer-id-application.p12" PKSC12_FILE="$HOME/developer-id-application.p12"
base64 --decode > "${PKSC12_FILE}" <<<"${APPLE_DEVELOPER_ID_BUNDLE}" base64 --decode > "${PKSC12_FILE}" <<<"${APPLE_DEVELOPER_ID_BUNDLE}"