fix(bridge_v2_api): don't disable schema check

This commit is contained in:
Thales Macedo Garitezi 2023-11-01 11:32:37 -03:00
parent 1e935e9eb4
commit 4bea65bf97
2 changed files with 21 additions and 7 deletions

View File

@ -70,11 +70,7 @@
namespace() -> "bridge_v2". namespace() -> "bridge_v2".
api_spec() -> api_spec() ->
%% TODO emqx_dashboard_swagger:spec(?MODULE, #{check_schema => true}).
%% The check_schema option needs to be set to false so we get the
%% query_string to the delete operation. We can change this once
%% we have fixed the schmea for the delete operation.
emqx_dashboard_swagger:spec(?MODULE, #{check_schema => false}).
paths() -> paths() ->
[ [
@ -127,6 +123,18 @@ param_path_id() ->
} }
)}. )}.
param_qs_delete_cascade() ->
{also_delete_dep_actions,
mk(
boolean(),
#{
in => query,
required => false,
default => false,
desc => ?DESC("desc_qs_also_delete_dep_actions")
}
)}.
param_path_operation_cluster() -> param_path_operation_cluster() ->
{operation, {operation,
mk( mk(
@ -235,7 +243,7 @@ schema("/bridges_v2/:id") ->
tags => [<<"bridges_v2">>], tags => [<<"bridges_v2">>],
summary => <<"Delete bridge">>, summary => <<"Delete bridge">>,
description => ?DESC("desc_api5"), description => ?DESC("desc_api5"),
parameters => [param_path_id()], parameters => [param_path_id(), param_qs_delete_cascade()],
responses => #{ responses => #{
204 => <<"Bridge deleted">>, 204 => <<"Bridge deleted">>,
400 => error_schema( 400 => error_schema(
@ -369,7 +377,7 @@ schema("/bridges_v2_probe") ->
?BRIDGE_NOT_FOUND(BridgeType, BridgeName) ?BRIDGE_NOT_FOUND(BridgeType, BridgeName)
end end
); );
'/bridges_v2/:id'(delete, #{bindings := #{id := Id}, query_string := Qs} = All) -> '/bridges_v2/:id'(delete, #{bindings := #{id := Id}, query_string := Qs}) ->
?TRY_PARSE_ID( ?TRY_PARSE_ID(
Id, Id,
case emqx_bridge_v2:lookup(BridgeType, BridgeName) of case emqx_bridge_v2:lookup(BridgeType, BridgeName) of

View File

@ -79,6 +79,12 @@ desc_param_path_id.desc:
desc_param_path_id.label: desc_param_path_id.label:
"""Bridge ID""" """Bridge ID"""
desc_qs_also_delete_dep_actions.desc:
"""Whether to cascade delete dependent actions."""
desc_qs_also_delete_dep_actions.label:
"""Cascade delete dependent actions?"""
desc_param_path_node.desc: desc_param_path_node.desc:
"""The node name, e.g. 'emqx@127.0.0.1'.""" """The node name, e.g. 'emqx@127.0.0.1'."""