From 478fcc6ffd52d9bc17ee58b773ca28cf8fb5c4dd Mon Sep 17 00:00:00 2001
From: Thales Macedo Garitezi <thalesmg@gmail.com>
Date: Fri, 13 Jan 2023 13:50:41 -0300
Subject: [PATCH] test: fix flaky test

---
 .../test/emqx_bridge_mqtt_SUITE.erl           | 23 +++++++++----------
 1 file changed, 11 insertions(+), 12 deletions(-)

diff --git a/apps/emqx_bridge/test/emqx_bridge_mqtt_SUITE.erl b/apps/emqx_bridge/test/emqx_bridge_mqtt_SUITE.erl
index 048c039bf..1f03863ae 100644
--- a/apps/emqx_bridge/test/emqx_bridge_mqtt_SUITE.erl
+++ b/apps/emqx_bridge/test/emqx_bridge_mqtt_SUITE.erl
@@ -953,18 +953,17 @@ t_mqtt_conn_bridge_egress_reconnect(_) ->
     ok.
 
 assert_mqtt_msg_received(Topic, Payload) ->
-    ?assert(
-        receive
-            {deliver, Topic, #message{payload = Payload}} ->
-                ct:pal("Got mqtt message: ~p on topic ~p", [Payload, Topic]),
-                true;
-            Msg ->
-                ct:pal("Unexpected Msg: ~p", [Msg]),
-                false
-        after 100 ->
-            false
-        end
-    ).
+    ct:pal("checking if ~p has been received on ~p", [Payload, Topic]),
+    receive
+        {deliver, Topic, #message{payload = Payload}} ->
+            ct:pal("Got mqtt message: ~p on topic ~p", [Payload, Topic]),
+            ok;
+        Msg ->
+            ct:pal("Unexpected Msg: ~p", [Msg]),
+            assert_mqtt_msg_received(Topic, Payload)
+    after 100 ->
+        ct:fail("timeout waiting for ~p on topic ~p", [Payload, Topic])
+    end.
 
 request(Method, Url, Body) ->
     request(<<"connector_admin">>, Method, Url, Body).