fix(dssnap): ensure idempotent write of empty chunks

2024-04-19 18:52:33 +02:00 · 2024-04-19 18:52:33 +02:00 · 43f8346c00
parent bac5100635
commit 43f8346c00
1 changed files with 3 additions and 1 deletions
--- a/apps/emqx_durable_storage/src/emqx_ds_storage_snapshot.erl
+++ b/apps/emqx_durable_storage/src/emqx_ds_storage_snapshot.erl
@ -267,7 +267,9 @@ new_writer_file(#writer{dirpath = DirPath}, RelPath) ->

 write_chunk_file(WFile0 = #wfile{fd = IoDev, pos = Pos, abspath = AbsPath}, Pos, More, Chunk) ->
    ChunkSize = byte_size(Chunk),
-    case file:write(IoDev, Chunk) of
+    case (ChunkSize > 0) andalso file:write(IoDev, Chunk) of
+        false ->
+            WFile0;
        ok ->
            WFile1 = WFile0#wfile{pos = Pos + ChunkSize},
            case More of