From 432eae6e55e2aaffe0419210152e5d77568c3214 Mon Sep 17 00:00:00 2001
From: William Yang <mscame@gmail.com>
Date: Tue, 6 Sep 2022 10:24:19 +0200
Subject: [PATCH] ci(xref): support emqx-ee profile

---
 scripts/xref-check.escript | 78 +++++++++++++++++++++-----------------
 scripts/xref_check.eterm   |  1 +
 2 files changed, 44 insertions(+), 35 deletions(-)

diff --git a/scripts/xref-check.escript b/scripts/xref-check.escript
index 36c4c57c2..a257734d4 100755
--- a/scripts/xref-check.escript
+++ b/scripts/xref-check.escript
@@ -7,44 +7,52 @@
 %%% instead all the filters, checks are defined in `xref_check.eterm`
 main(_) ->
     {ok, [Jobs]} = file:consult("scripts/xref_check.eterm"),
-    lists:foreach(fun(#{ name := Name
-                       , analysis := Analysis
-                       , excl_apps := ExclApps
-                       , excl_mods := ExclMods
-                       , filters := Filters
-                       }) ->
-                          xref:start(Name),
-                          Tid = ets:new(Name, [ordered_set, named_table]),
-                          xref:set_default(Name, [{verbose,false}, {warnings,false}]),
-                          xref:add_release(Name, "_build/emqx/rel/emqx/lib/"),
-                          xref:add_application(Name, code:lib_dir(erts)),
-                          [ case xref:remove_application(Name, App) of
-                                ok -> ok;
-                                {error, xref_base, {no_such_application, _}} -> ok
-                            end || App <- ExclApps
-                          ],
-
-                          [case xref:remove_module(Name, M) of
-                               ok -> ok;
-                               %% but in doc it should return '{error, module(), Reason}`
-                               {error, xref_base, {no_such_module, M}} -> ok
-                           end || M <- ExclMods
-                          ],
-                          ModuleInfos = xref:info(Name, modules),
-                          LibInfos = xref:info(Name, modules),
-                          true = ets:insert(Tid, ModuleInfos ++ LibInfos),
-                          {ok, Res0} = xref:analyse(Name, Analysis),
-                          Res = Res0 -- Filters,
-                          Res =/= [] andalso
-                              begin
-                                  put(is_warn_found, true),
-                                  io:format("** Warnings for ~p~n : ~p~n", [Name, Res])
-                              end,
-                          xref:stop(Name)
-                  end, Jobs),
+    lists:foreach(fun(J) -> do_check(J) end, Jobs),
     case get(is_warn_found) of
         true ->
             halt(1);
         _ ->
             ok
     end.
+
+do_check(#{ name := Name
+          , analysis := Analysis
+          , excl_apps := ExclApps
+          , excl_mods := ExclMods
+          , filters := Filters
+          }) ->
+    xref:start(Name),
+    %% Build a table for later printing more informative warnings.
+    %% The table is currently not in use.
+    Tid = ets:new(Name, [ordered_set, named_table]),
+    xref:set_default(Name, [{verbose,false}, {warnings,false}]),
+    Profile = case filelib:is_file("EMQX_ENTERPRISE") of
+                  true -> 'emqx-ee';
+                  false -> emqx
+              end,
+    Dir = filename:join(["_build/",  Profile, "rel/emqx/lib/"]),
+    xref:add_release(Name, Dir),
+    xref:add_application(Name, code:lib_dir(erts)),
+    [ case xref:remove_application(Name, App) of
+          ok -> ok;
+          {error, xref_base, {no_such_application, _}} -> ok
+      end || App <- ExclApps
+    ],
+
+    [case xref:remove_module(Name, M) of
+         ok -> ok;
+         %% but in doc it should return '{error, module(), Reason}`
+         {error, xref_base, {no_such_module, M}} -> ok
+     end || M <- ExclMods
+    ],
+    ModuleInfos = xref:info(Name, modules),
+    LibInfos = xref:info(Name, libraries),
+    true = ets:insert(Tid, ModuleInfos ++ LibInfos),
+    {ok, Res0} = xref:analyse(Name, Analysis),
+    Res = Res0 -- Filters,
+    Res =/= [] andalso
+        begin
+            put(is_warn_found, true),
+            io:format("** Warnings for ~p~n : ~p~n", [Name, Res])
+        end,
+    xref:stop(Name).
diff --git a/scripts/xref_check.eterm b/scripts/xref_check.eterm
index 9616173ca..d09bee6a8 100644
--- a/scripts/xref_check.eterm
+++ b/scripts/xref_check.eterm
@@ -1,3 +1,4 @@
+%% -*- mode: erlang; -*-
 [ %% Check undefined_function_calls
   #{ name => undefined_function_calls
    , analysis => undefined_function_calls