From ea6f5764bb4699a251c15afdf3f99aa622e949a9 Mon Sep 17 00:00:00 2001
From: Serge Tupchii <serge.tupchii@protonmail.com>
Date: Tue, 12 Dec 2023 12:05:46 +0200
Subject: [PATCH 1/4] test: remove debug message

---
 apps/emqx_opentelemetry/test/emqx_otel_schema_SUITE.erl | 1 -
 1 file changed, 1 deletion(-)

diff --git a/apps/emqx_opentelemetry/test/emqx_otel_schema_SUITE.erl b/apps/emqx_opentelemetry/test/emqx_otel_schema_SUITE.erl
index f5682dcad..abc6548f9 100644
--- a/apps/emqx_opentelemetry/test/emqx_otel_schema_SUITE.erl
+++ b/apps/emqx_opentelemetry/test/emqx_otel_schema_SUITE.erl
@@ -164,7 +164,6 @@ t_old_conf_disabled_exporter(_Config) ->
     ?assertNot(erlang:is_map_key(interval, maps:get(exporter, OtelConf))).
 
 t_old_conf_exporter(_Config) ->
-    io:format(user, "TC running: ~p~n", [?FUNCTION_NAME]),
     OtelConf = emqx:get_config([opentelemetry]),
     ?assertMatch(
         #{

From f529bda8b7f8f519cf56bed0914816d29533433d Mon Sep 17 00:00:00 2001
From: Serge Tupchii <serge.tupchii@protonmail.com>
Date: Tue, 12 Dec 2023 12:07:59 +0200
Subject: [PATCH 2/4] fix(opentelemetry_schema): decrease
 scheduled_delay/interval importance to medium

These fields should be shown in API schema.
---
 apps/emqx_opentelemetry/src/emqx_otel_schema.erl | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/apps/emqx_opentelemetry/src/emqx_otel_schema.erl b/apps/emqx_opentelemetry/src/emqx_otel_schema.erl
index bcd0b8dcf..420bf23f2 100644
--- a/apps/emqx_opentelemetry/src/emqx_otel_schema.erl
+++ b/apps/emqx_opentelemetry/src/emqx_otel_schema.erl
@@ -108,7 +108,7 @@ fields("otel_metrics") ->
                     aliases => [scheduled_delay],
                     default => <<"10s">>,
                     desc => ?DESC(scheduled_delay),
-                    importance => ?IMPORTANCE_HIDDEN
+                    importance => ?IMPORTANCE_MEDIUM
                 }
             )}
     ];
@@ -156,7 +156,7 @@ fields("otel_logs") ->
                 #{
                     default => <<"1s">>,
                     desc => ?DESC(scheduled_delay),
-                    importance => ?IMPORTANCE_HIDDEN
+                    importance => ?IMPORTANCE_MEDIUM
                 }
             )}
     ];
@@ -195,7 +195,7 @@ fields("otel_traces") ->
                 #{
                     default => <<"5s">>,
                     desc => ?DESC(scheduled_delay),
-                    importance => ?IMPORTANCE_HIDDEN
+                    importance => ?IMPORTANCE_MEDIUM
                 }
             )},
         {filter,

From 36b12a01c96fe829e6cb05c756332184bfa23cb3 Mon Sep 17 00:00:00 2001
From: Serge Tupchii <serge.tupchii@protonmail.com>
Date: Tue, 12 Dec 2023 13:06:20 +0200
Subject: [PATCH 3/4] chore: fix typos in comments

---
 apps/emqx_opentelemetry/test/emqx_otel_trace_SUITE.erl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/apps/emqx_opentelemetry/test/emqx_otel_trace_SUITE.erl b/apps/emqx_opentelemetry/test/emqx_otel_trace_SUITE.erl
index 88917d7e3..f1554094f 100644
--- a/apps/emqx_opentelemetry/test/emqx_otel_trace_SUITE.erl
+++ b/apps/emqx_opentelemetry/test/emqx_otel_trace_SUITE.erl
@@ -29,7 +29,7 @@
 %% How to run it locally:
 %%  1. Uncomment networks in .ci/docker-compose-file/docker-compose-otel.yaml,
 %%     Uncomment OTLP gRPC ports mappings for otel-collector and otel-collector-tls services.
-%%     Uncomment jaeger-all-in-one prots maooing.
+%%     Uncomment jaeger-all-in-one ports mapping.
 %%  2. Start deps services:
 %%     DOCKER_USER="$(id -u)" docker-compose -f .ci/docker-compose-file/docker-compose-otel.yaml up
 %%  3. Run tests with special env variables:

From 3c3452c1dd2c702c174940e6f60cb41a0839ff4a Mon Sep 17 00:00:00 2001
From: Serge Tupchii <serge.tupchii@protonmail.com>
Date: Tue, 12 Dec 2023 13:07:08 +0200
Subject: [PATCH 4/4] fix(emqx_otel_schema): add `enable` field to SSL opts

---
 apps/emqx_opentelemetry/src/emqx_otel_config.erl | 2 +-
 apps/emqx_opentelemetry/src/emqx_otel_schema.erl | 7 ++-----
 2 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/apps/emqx_opentelemetry/src/emqx_otel_config.erl b/apps/emqx_opentelemetry/src/emqx_otel_config.erl
index 0d2f9988b..c16b3385a 100644
--- a/apps/emqx_opentelemetry/src/emqx_otel_config.erl
+++ b/apps/emqx_opentelemetry/src/emqx_otel_config.erl
@@ -150,7 +150,7 @@ tr_handler_conf(#{logs := LogsConf, exporter := ExporterConf}) ->
 ssl_opts(Endpoint, SSLOpts) ->
     case is_ssl(Endpoint) of
         true ->
-            emqx_tls_lib:to_client_opts(SSLOpts#{enable => true});
+            emqx_tls_lib:to_client_opts(SSLOpts);
         false ->
             []
     end.
diff --git a/apps/emqx_opentelemetry/src/emqx_otel_schema.erl b/apps/emqx_opentelemetry/src/emqx_otel_schema.erl
index 420bf23f2..be14a2b29 100644
--- a/apps/emqx_opentelemetry/src/emqx_otel_schema.erl
+++ b/apps/emqx_opentelemetry/src/emqx_otel_schema.erl
@@ -230,16 +230,14 @@ fields("otel_exporter") ->
             )},
         {ssl_options,
             ?HOCON(
-                ?R_REF("ssl_opts"),
+                ?R_REF(emqx_schema, "ssl_client_opts"),
                 #{
                     desc => ?DESC(exporter_ssl),
+                    default => #{<<"enable">> => false},
                     importance => ?IMPORTANCE_LOW
                 }
             )}
     ];
-fields("ssl_opts") ->
-    Schema = emqx_schema:client_ssl_opts_schema(#{}),
-    lists:keydelete("enable", 1, Schema);
 fields("trace_filter") ->
     %% More filters can be implemented in future, e.g. topic, clientid
     [
@@ -259,6 +257,5 @@ desc("otel_exporter") -> ?DESC(otel_exporter);
 desc("otel_logs") -> ?DESC(otel_logs);
 desc("otel_metrics") -> ?DESC(otel_metrics);
 desc("otel_traces") -> ?DESC(otel_traces);
-desc("ssl_opts") -> ?DESC(exporter_ssl);
 desc("trace_filter") -> ?DESC(trace_filter);
 desc(_) -> undefined.