yuanbiao
/
emqx
1
0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(sessds): use milder log level for regular error conditions 

Especially when such events are emitted in (potentially) tight loops,
i.e. pulling messages from iterators pointing to remote shards.
This commit is contained in:
Andrew Mayorov 2024-05-08 17:40:08 +02:00
parent 4403b4f5ce
commit 3e956e8711
No known key found for this signature in database
GPG Key ID: 2837C62ACFBFED5D
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
apps/emqx/src/emqx_persistent_session_ds.erl
View File

@ -622,7 +622,7 @@ replay_streams(Session0 = #{replay := [{StreamKey, Srs0} | Rest]}, ClientInfo) -
replay_streams(Session#{replay := Rest}, ClientInfo); replay_streams(Session#{replay := Rest}, ClientInfo);
{error, recoverable, Reason} -> {error, recoverable, Reason} ->
RetryTimeout = ?TIMEOUT_RETRY_REPLAY, RetryTimeout = ?TIMEOUT_RETRY_REPLAY,
?SLOG(warning, #{ ?SLOG(debug, #{
msg => "failed_to_fetch_replay_batch", msg => "failed_to_fetch_replay_batch",
stream => StreamKey, stream => StreamKey,
reason => Reason, reason => Reason,
@ -925,7 +925,7 @@ new_batch({StreamKey, Srs0}, BatchSize, Session0 = #{s := S0}, ClientInfo) ->
Session#{s => S}; Session#{s => S};
{error, Class, Reason} -> {error, Class, Reason} ->
%% TODO: Handle unrecoverable error. %% TODO: Handle unrecoverable error.
?SLOG(info, #{ ?SLOG(debug, #{
msg => "failed_to_fetch_batch", msg => "failed_to_fetch_batch",
stream => StreamKey, stream => StreamKey,
reason => Reason, reason => Reason,

2
apps/emqx/src/emqx_persistent_session_ds_stream_scheduler.erl
View File

@ -220,7 +220,7 @@ ensure_iterator(TopicFilter, StartTime, SubId, SStateId, {{RankX, RankY}, Stream
}, },
emqx_persistent_session_ds_state:put_stream(Key, NewStreamState, S); emqx_persistent_session_ds_state:put_stream(Key, NewStreamState, S);
{error, recoverable, Reason} -> {error, recoverable, Reason} ->
?SLOG(warning, #{ ?SLOG(debug, #{
msg => "failed_to_initialize_stream_iterator", msg => "failed_to_initialize_stream_iterator",
stream => Stream, stream => Stream,
class => recoverable, class => recoverable,