From 3d47e28fa98c98ff635c20a8d888a4aa50ef7924 Mon Sep 17 00:00:00 2001
From: Zhongwen Deng <zhongwencool@gmail.com>
Date: Mon, 25 Apr 2022 20:59:50 +0800
Subject: [PATCH] fix: responses don't support object, use ref

---
 apps/emqx_dashboard/i18n/emqx_dashboard_api_i18n.conf | 6 ++++++
 apps/emqx_dashboard/src/emqx_dashboard_api.erl        | 6 ++++--
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/apps/emqx_dashboard/i18n/emqx_dashboard_api_i18n.conf b/apps/emqx_dashboard/i18n/emqx_dashboard_api_i18n.conf
index 205483e61..f50811cbb 100644
--- a/apps/emqx_dashboard/i18n/emqx_dashboard_api_i18n.conf
+++ b/apps/emqx_dashboard/i18n/emqx_dashboard_api_i18n.conf
@@ -139,5 +139,11 @@ emqx_dashboard_api {
             zh: """新密码"""
         }
     }
+    login_failed_response400 {
+        desc {
+            en: """Login failed. Bad username or password"""
+            zh: """登录失败。用户名或密码错误"""
+        }
+    }
 
 }
diff --git a/apps/emqx_dashboard/src/emqx_dashboard_api.erl b/apps/emqx_dashboard/src/emqx_dashboard_api.erl
index 81d7965d0..60991cea0 100644
--- a/apps/emqx_dashboard/src/emqx_dashboard_api.erl
+++ b/apps/emqx_dashboard/src/emqx_dashboard_api.erl
@@ -101,8 +101,8 @@ schema("/users") ->
             tags => [<<"dashboard">>],
             desc => ?DESC(list_users_api),
             responses => #{
-                200 => mk(array(fields([username, description])),
-                        #{desc => ?DESC(list_users_api)})
+                200 => mk(array(hoconsc:ref(user)),
+                    #{desc => ?DESC(list_users_api)})
             }
         },
         post => #{
@@ -164,6 +164,8 @@ response_schema(401) ->
 response_schema(404) ->
     emqx_dashboard_swagger:error_codes([?USER_NOT_FOUND], ?DESC(users_api404)).
 
+fields(user) ->
+    fields([username, description]);
 fields(List) ->
     [field(Key) || Key <- List].