yuanbiao
/
emqx
1
0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(emqx_bridge): let it crash instead of 400 on failed reset

This commit is contained in:
Stefan Strigler 2023-03-02 09:55:38 +01:00
parent 4c23ab097d
commit 39e1cf9502
1 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
apps/emqx_bridge/src/emqx_bridge_api.erl
View File

@ -386,7 +386,6 @@ schema("/bridges/:id/metrics/reset") ->
parameters => [param_path_id()], parameters => [param_path_id()],
responses => #{ responses => #{
204 => <<"Reset success">>, 204 => <<"Reset success">>,
400 => error_schema(['BAD_REQUEST'], "RPC Call Failed"),
404 => error_schema('NOT_FOUND', "Bridge not found") 404 => error_schema('NOT_FOUND', "Bridge not found")
} }
} }
@ -541,13 +540,11 @@ schema("/bridges_probe") ->
'/bridges/:id/metrics/reset'(put, #{bindings := #{id := Id}}) -> '/bridges/:id/metrics/reset'(put, #{bindings := #{id := Id}}) ->
?TRY_PARSE_ID( ?TRY_PARSE_ID(
Id, Id,
case begin
emqx_bridge_resource:reset_metrics( ok = emqx_bridge_resource:reset_metrics(
emqx_bridge_resource:resource_id(BridgeType, BridgeName) emqx_bridge_resource:resource_id(BridgeType, BridgeName)
) ),
of {204}
ok -> {204};
Reason -> {400, error_msg('BAD_REQUEST', Reason)}
end end
). ).