fix(ds): Improve comments

This commit is contained in:
ieQu1 2024-07-05 00:12:19 +02:00
parent d7732a6aac
commit 3721be65ee
No known key found for this signature in database
GPG Key ID: 488654DF3FED6FDE
2 changed files with 13 additions and 5 deletions

View File

@ -101,7 +101,9 @@
-record(it, { -record(it, {
static_index :: emqx_ds_lts:static_key(), static_index :: emqx_ds_lts:static_key(),
%% Minimal timestamp of the next message:
ts :: ts(), ts :: ts(),
%% Compressed topic filter:
compressed_tf :: binary() compressed_tf :: binary()
}). }).
@ -555,8 +557,16 @@ next_step(
next_step(S, StaticIdx, CompressedTF, Iterators, NextTS, {seek, NextTS}) next_step(S, StaticIdx, CompressedTF, Iterators, NextTS, {seek, NextTS})
end; end;
NextTS when NextTS > ExpectedTS, N > 0 -> NextTS when NextTS > ExpectedTS, N > 0 ->
%% Next index level is not what we expect. Reset
%% search to the first wilcard index, but continue
%% from `NextTS'.
%%
%% Note: if `NextTS > ExpectedTS' and `N =:= 0',
%% it means the upper (replication) level is
%% broken and supplied us NextTS that advenced
%% past the point of time that can be safely read.
%% We don't handle it here.
inc_counter(?DS_SKIPSTREAM_LTS_MISS), inc_counter(?DS_SKIPSTREAM_LTS_MISS),
%% Next index level is not what we expect.
{seek, NextTS} {seek, NextTS}
end end
end. end.

View File

@ -2,8 +2,6 @@ Add a new version of `wildcard_optimized` storage layout for the durable storage
Improvements: Improvements:
- New layout does not introduce latency - New layout does not have an inherent latency
- On-disk serialization of MQTT messages is much more efficient - MQTT messages are serialized into a much more space-efficient format
- Metadata is encoded more efficiently
- Message topic is compressed