From 32376c7cf962da1b4f6fe3f06f67c87523d872db Mon Sep 17 00:00:00 2001
From: JimMoen <LnJimMoen@outlook.com>
Date: Thu, 29 Sep 2022 16:21:40 +0800
Subject: [PATCH] fix(rule_func): refine num funcs error info type unsupported

---
 apps/emqx_rule_engine/src/emqx_rule_funcs.erl | 28 +++++++++++++------
 1 file changed, 20 insertions(+), 8 deletions(-)

diff --git a/apps/emqx_rule_engine/src/emqx_rule_funcs.erl b/apps/emqx_rule_engine/src/emqx_rule_funcs.erl
index a4791a94d..da345665b 100644
--- a/apps/emqx_rule_engine/src/emqx_rule_funcs.erl
+++ b/apps/emqx_rule_engine/src/emqx_rule_funcs.erl
@@ -332,34 +332,46 @@ null() ->
 %% Arithmetic Funcs
 %%------------------------------------------------------------------------------
 
+-define(OPERATOR_TYPE_ERROR, unsupported_function_operator_type).
+
 %% plus 2 numbers
 '+'(X, Y) when is_number(X), is_number(Y) ->
     X + Y;
-
 %% concat 2 strings
 '+'(X, Y) when is_binary(X), is_binary(Y) ->
     concat(X, Y);
-
 %% unsupported type implicit conversion
 '+'(X, Y)
   when (is_number(X) andalso is_binary(Y)) orelse
        (is_binary(X) andalso is_number(Y)) ->
-    error(unsupported_type_implicit_conversion).
+    error(unsupported_type_implicit_conversion);
+'+'(_, _) ->
+    error(?OPERATOR_TYPE_ERROR).
 
 '-'(X, Y) when is_number(X), is_number(Y) ->
-    X - Y.
+    X - Y;
+'-'(_, _) ->
+    error(?OPERATOR_TYPE_ERROR).
 
 '*'(X, Y) when is_number(X), is_number(Y) ->
-    X * Y.
+    X * Y;
+'*'(_, _) ->
+    error(?OPERATOR_TYPE_ERROR).
 
 '/'(X, Y) when is_number(X), is_number(Y) ->
-    X / Y.
+    X / Y;
+'/'(_, _) ->
+    error(?OPERATOR_TYPE_ERROR).
 
 'div'(X, Y) when is_integer(X), is_integer(Y) ->
-    X div Y.
+    X div Y;
+'div'(_, _) ->
+    error(?OPERATOR_TYPE_ERROR).
 
 mod(X, Y) when is_integer(X), is_integer(Y) ->
-    X rem Y.
+    X rem Y;
+mod(_, _) ->
+    error(?OPERATOR_TYPE_ERROR).
 
 eq(X, Y) ->
     X == Y.