From 30d986c31825076cf588f0ecb49d4e27c1453b4d Mon Sep 17 00:00:00 2001 From: Gilbert Wong Date: Sat, 29 Sep 2018 19:17:58 +0800 Subject: [PATCH] Add warning log for unauthored subscribe Prior to this change, there is no log for unauthored log, it is difficult to find the problem when subscription error occured. --- src/emqx_protocol.erl | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/emqx_protocol.erl b/src/emqx_protocol.erl index 1fb80c0ce..861fc68a8 100644 --- a/src/emqx_protocol.erl +++ b/src/emqx_protocol.erl @@ -747,7 +747,11 @@ check_sub_acl(TopicFilters, PState) -> fun({Topic, SubOpts}, {Ok, Acc}) -> case emqx_access_control:check_acl(Credentials, subscribe, Topic) of allow -> {Ok, [{Topic, SubOpts}|Acc]}; - deny -> {error, [{Topic, SubOpts#{rc := ?RC_NOT_AUTHORIZED}}|Acc]} + deny -> + emqx_logger:warning([{client, PState#pstate.client_id}], + "ACL(~s) Cannot SUBSCRIBE ~p for ACL Deny", + [PState#pstate.client_id, Topic]), + {error, [{Topic, SubOpts#{rc := ?RC_NOT_AUTHORIZED}}|Acc]} end end, {ok, []}, TopicFilters).