yuanbiao
/
emqx
1
0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(bpapi): Make error messages nicer

This commit is contained in:
ieQu1 2022-07-01 09:33:54 +02:00
parent 88746c7c11
commit 2f7078f314
1 changed files with 16 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
apps/emqx/test/emqx_static_checks.erl
View File

@ -29,9 +29,12 @@ init_per_suite(Config) ->
end_per_suite(_Config) -> end_per_suite(_Config) ->
logger:notice( logger:notice(
asciiart:visible(
$=,
"If this test suite failed, and you are unsure why, read this:~n" "If this test suite failed, and you are unsure why, read this:~n"
"https://github.com/emqx/emqx/blob/master/apps/emqx/src/bpapi/README.md", "https://github.com/emqx/emqx/blob/master/apps/emqx/src/bpapi/README.md",
[] []
)
). ).
check_if_versions_consistent(OldData, NewData) -> check_if_versions_consistent(OldData, NewData) ->
@ -47,9 +50,14 @@ t_run_check(_) ->
check_if_versions_consistent(OldData, NewData) orelse check_if_versions_consistent(OldData, NewData) orelse
begin begin
logger:critical( logger:critical(
"BPAPI versions were changed, but not committed to the repo.\n" asciiart:visible(
"Run 'make && make static_checks' and then add the changed " $=,
"'bpapi.versions' files to the commit." "BPAPI versions were changed, but not committed to the repo.\n\n"
"Versions file is generated automatically, to update it, run\n"
"'make && make static_checks' locally, and then add the\n"
"changed 'bpapi.versions' files to the commit.\n",
[]
)
), ),
error(version_mismatch) error(version_mismatch)
end, end,
@ -59,6 +67,8 @@ t_run_check(_) ->
logger:info("Backplane API dump files: ~p", [BpapiDumps]), logger:info("Backplane API dump files: ~p", [BpapiDumps]),
?assert(emqx_bpapi_static_checks:check_compat(BpapiDumps)) ?assert(emqx_bpapi_static_checks:check_compat(BpapiDumps))
catch catch
error:version_mismatch ->
error(tc_failed);
EC:Err:Stack -> EC:Err:Stack ->
logger:critical("Test suite failed: ~p:~p~nStack:~p", [EC, Err, Stack]), logger:critical("Test suite failed: ~p:~p~nStack:~p", [EC, Err, Stack]),
error(tc_failed) error(tc_failed)