refactor(review): apply code improvements

This commit is contained in:
Thales Macedo Garitezi 2021-11-05 08:21:14 -03:00
parent c5869b62dc
commit 29be556e9a
No known key found for this signature in database
GPG Key ID: DD279F8152A9B6DD
1 changed files with 3 additions and 4 deletions

View File

@ -148,13 +148,12 @@ unregister_channel(ClientId) when is_binary(ClientId) ->
do_unregister_channel(Chan) -> do_unregister_channel(Chan) ->
ok = emqx_cm_registry:unregister_channel(Chan), ok = emqx_cm_registry:unregister_channel(Chan),
true = ets:delete(?CHAN_CONN_TAB, Chan), true = ets:delete(?CHAN_CONN_TAB, Chan),
case ets:lookup(?CHAN_INFO_TAB, Chan) of case ets:take(?CHAN_INFO_TAB, Chan) of
[{_, #{conn_state := connected}, _}] -> [{_, #{conn_state := connected}, _}] ->
decrement_connected_client_count(); decrement_connected_client_count();
_ -> _ ->
skip ok
end, end,
true = ets:delete(?CHAN_INFO_TAB, Chan),
ets:delete_object(?CHAN_TAB, Chan). ets:delete_object(?CHAN_TAB, Chan).
-spec(connection_closed(emqx_types:clientid()) -> true). -spec(connection_closed(emqx_types:clientid()) -> true).
@ -440,7 +439,7 @@ rpc_call(Node, Fun, Args, Timeout) ->
%% @private %% @private
cast(Msg) -> gen_server:cast(?CM, Msg). cast(Msg) -> gen_server:cast(?CM, Msg).
call(Msg) -> gen_server:call(?CM, Msg). call(Msg) -> gen_server:call(?CM, Msg, infinity).
%%-------------------------------------------------------------------- %%--------------------------------------------------------------------
%% gen_server callbacks %% gen_server callbacks