yuanbiao
/
emqx
1
0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #6310 from emqx/test-fix-possible-flakiness 

test(flakiness): prevent possible flakiness in test

If the spawned process doesn't have enough time to be properly set up,
the returned stacktrace may be empty, making the test fail. By
synchronizing the startup, we know that the process will have a proper
stacktrace by the time of the assertion.
This commit is contained in:
Thales Macedo Garitezi 2021-11-26 08:09:05 -03:00 committed by GitHub
parent 759b03a6ad d6288a0b70
commit 284619ef86
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
apps/emqx/test/emqx_sys_mon_SUITE.erl
View File

@ -93,7 +93,13 @@ t_procinfo(_) ->
?assertEqual([{pid, self()}], emqx_sys_mon:procinfo(self())). ?assertEqual([{pid, self()}], emqx_sys_mon:procinfo(self())).
t_procinfo_initial_call_and_stacktrace(_) -> t_procinfo_initial_call_and_stacktrace(_) ->
SomePid = proc_lib:spawn(?MODULE, some_function, [arg1, arg2]), SomePid = proc_lib:spawn(?MODULE, some_function, [self(), arg2]),
receive
{spawned, SomePid} ->
ok
after 100 ->
error(process_not_spawned)
end,
ProcInfo = emqx_sys_mon:procinfo(SomePid), ProcInfo = emqx_sys_mon:procinfo(SomePid),
?assertEqual( ?assertEqual(
{?MODULE, some_function, ['Argument__1','Argument__2']}, {?MODULE, some_function, ['Argument__1','Argument__2']},
@ -139,7 +145,8 @@ validate_sys_mon_info(PidOrPort, SysMonName, ValidateInfo, InfoOrPort) ->
fmt(Fmt, Args) -> lists:flatten(io_lib:format(Fmt, Args)). fmt(Fmt, Args) -> lists:flatten(io_lib:format(Fmt, Args)).
some_function(_Arg1, _Arg2) -> some_function(Parent, _Arg2) ->
Parent ! {spawned, self()},
receive receive
stop -> stop ->
ok ok