yuanbiao
/
emqx
1
0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor: refine function name

This commit is contained in:
JimMoen 2024-04-24 17:36:24 +08:00
parent 2686a66b14
commit 27d1f91cac
No known key found for this signature in database
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
apps/emqx_plugins/src/emqx_plugins_serde.erl
View File

@ -22,7 +22,7 @@
%% API %% API
-export([ -export([
start_link/0, start_link/0,
get_serde/1, lookup_serde/1,
add_schema/2, add_schema/2,
get_schema/1, get_schema/1,
delete_schema/1 delete_schema/1
@ -49,8 +49,8 @@
start_link() -> start_link() ->
gen_server:start_link({local, ?MODULE}, ?MODULE, [], []). gen_server:start_link({local, ?MODULE}, ?MODULE, [], []).
-spec get_serde(schema_name()) -> {ok, plugin_schema_serde()} | {error, not_found}. -spec lookup_serde(schema_name()) -> {ok, plugin_schema_serde()} | {error, not_found}.
get_serde(SchemaName) -> lookup_serde(SchemaName) ->
case ets:lookup(?PLUGIN_SERDE_TAB, to_bin(SchemaName)) of case ets:lookup(?PLUGIN_SERDE_TAB, to_bin(SchemaName)) of
[] -> [] ->
{error, not_found}; {error, not_found};
@ -60,7 +60,7 @@ get_serde(SchemaName) ->
-spec add_schema(schema_name(), avsc()) -> ok | {error, term()}. -spec add_schema(schema_name(), avsc()) -> ok | {error, term()}.
add_schema(Name, Avsc) -> add_schema(Name, Avsc) ->
case get_serde(Name) of case lookup_serde(Name) of
{ok, _Serde} -> {ok, _Serde} ->
?SLOG(warning, #{msg => "plugin_avsc_schema_already_exists", name_vsn => Name}), ?SLOG(warning, #{msg => "plugin_avsc_schema_already_exists", name_vsn => Name}),
{error, already_exists}; {error, already_exists};
@ -90,7 +90,7 @@ get_schema(NameVsn) ->
-spec delete_schema(schema_name()) -> ok | {error, term()}. -spec delete_schema(schema_name()) -> ok | {error, term()}.
delete_schema(NameVsn) -> delete_schema(NameVsn) ->
case get_serde(NameVsn) of case lookup_serde(NameVsn) of
{ok, _Serde} -> {ok, _Serde} ->
async_delete_serdes([NameVsn]), async_delete_serdes([NameVsn]),
ok; ok;
@ -201,7 +201,7 @@ make_serde(NameVsn, Avsc) ->
ensure_serde_absent(Name) when not is_binary(Name) -> ensure_serde_absent(Name) when not is_binary(Name) ->
ensure_serde_absent(to_bin(Name)); ensure_serde_absent(to_bin(Name));
ensure_serde_absent(Name) -> ensure_serde_absent(Name) ->
case get_serde(Name) of case lookup_serde(Name) of
{ok, _Serde} -> {ok, _Serde} ->
_ = ets:delete(?PLUGIN_SERDE_TAB, Name), _ = ets:delete(?PLUGIN_SERDE_TAB, Name),
ok; ok;
@ -238,7 +238,7 @@ with_serde(WhichOp, Fun) ->
eval_serde_fun(Op, ErrMsg, SerdeName, Args) -> eval_serde_fun(Op, ErrMsg, SerdeName, Args) ->
fun() -> fun() ->
case get_serde(SerdeName) of case lookup_serde(SerdeName) of
{ok, Serde} -> {ok, Serde} ->
eval_serde(Op, Serde, Args); eval_serde(Op, Serde, Args);
{error, not_found} -> {error, not_found} ->