diff --git a/src/emqx.appup.src b/src/emqx.appup.src index 7322f75f5..f70d41198 100644 --- a/src/emqx.appup.src +++ b/src/emqx.appup.src @@ -31,12 +31,16 @@ ]}, {<<"4.2.[23]">>, [ {add_module, emqx_congestion}, + {load_module, emqx_frame, brutal_purge, soft_purge, []}, {load_module, emqx_alarm, brutal_purge, soft_purge, []}, {load_module, emqx_channel, brutal_purge, soft_purge, []}, {load_module, emqx_connection, brutal_purge, soft_purge, []}, {load_module, emqx_os_mon, brutal_purge, soft_purge, []}, {load_module, emqx_shared_sub, brutal_purge, soft_purge, []} ]}, + {<<"4.2.4">>, [ + {load_module, emqx_frame, brutal_purge, soft_purge, []} + ]}, {<<".*">>, []} ], [ @@ -73,8 +77,12 @@ {load_module, emqx_connection, brutal_purge, soft_purge, []}, {load_module, emqx_channel, brutal_purge, soft_purge, []}, {load_module, emqx_alarm, brutal_purge, soft_purge, []}, + {load_module, emqx_frame, brutal_purge, soft_purge, []}, {delete_module, emqx_congestion} ]}, + {<<"4.2.4">>, [ + {load_module, emqx_frame, brutal_purge, soft_purge, []} + ]}, {<<".*">>, []} ] }. diff --git a/src/emqx_frame.erl b/src/emqx_frame.erl index d09b8416e..94fbda4b7 100644 --- a/src/emqx_frame.erl +++ b/src/emqx_frame.erl @@ -141,6 +141,9 @@ parse_remaining_len(<<0:8, Rest/binary>>, Header, 1, 0, Options) -> %% Match PUBACK, PUBREC, PUBREL, PUBCOMP, UNSUBACK... parse_remaining_len(<<0:1, 2:7, Rest/binary>>, Header, 1, 0, Options) -> parse_frame(Rest, Header, 2, Options); +parse_remaining_len(<<1:1, _Len:7, _Rest/binary>>, _Header, Multiplier, _Value, _Options) + when Multiplier > 2097152 -> + error(malformed_variable_byte_integer); parse_remaining_len(<<1:1, Len:7, Rest/binary>>, Header, Multiplier, Value, Options) -> parse_remaining_len(Rest, Header, Multiplier * ?HIGHBIT, Value + Len * Multiplier, Options); parse_remaining_len(<<0:1, Len:7, Rest/binary>>, Header, Multiplier, Value, diff --git a/test/emqx_frame_SUITE.erl b/test/emqx_frame_SUITE.erl index 5d4e146db..aef88cf9f 100644 --- a/test/emqx_frame_SUITE.erl +++ b/test/emqx_frame_SUITE.erl @@ -42,7 +42,8 @@ all() -> groups() -> [{parse, [parallel], [t_parse_cont, - t_parse_frame_too_large + t_parse_frame_too_large, + t_parse_frame_malformed_variable_byte_integer ]}, {connect, [parallel], [t_serialize_parse_v3_connect, @@ -129,6 +130,12 @@ t_parse_frame_too_large(_) -> ?catch_error(frame_too_large, parse_serialize(Packet, #{max_size => 512})), ?assertEqual(Packet, parse_serialize(Packet, #{max_size => 2048, version => ?MQTT_PROTO_V4})). +t_parse_frame_malformed_variable_byte_integer(_) -> + MalformedPayload = << <<16#80>> || _ <- lists:seq(1, 4) >>, + ParseState = emqx_frame:initial_parse_state(#{}), + ?catch_error(malformed_variable_byte_integer, + emqx_frame:parse(MalformedPayload, ParseState)). + t_serialize_parse_v3_connect(_) -> Bin = <<16,37,0,6,77,81,73,115,100,112,3,2,0,60,0,23,109,111,115, 113,112,117, 98,47,49,48,52,53,49,45,105,77,97,99,46,108,