From 225ebdaa87a035fcc5d72350965027f0441227d7 Mon Sep 17 00:00:00 2001 From: Zaiming Shi Date: Tue, 28 Sep 2021 18:15:32 +0200 Subject: [PATCH] fix(frame): simlify error excption context We should not raise error with the exact context after logging it because it will end up duplicated in the log --- apps/emqx/src/emqx_connection.erl | 2 +- apps/emqx/src/emqx_ws_connection.erl | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/apps/emqx/src/emqx_connection.erl b/apps/emqx/src/emqx_connection.erl index 2fe3ea8c9..8d0e74313 100644 --- a/apps/emqx/src/emqx_connection.erl +++ b/apps/emqx/src/emqx_connection.erl @@ -726,7 +726,7 @@ serialize_and_inc_stats_fun(#state{serialize = Serialize}) -> ?SLOG(error, #{ input_packet => Packet , exception => Reason , stacktrace => Stacktrace}), - erlang:raise(error, Reason, Stacktrace) + erlang:error(frame_serialize_error) end end. diff --git a/apps/emqx/src/emqx_ws_connection.erl b/apps/emqx/src/emqx_ws_connection.erl index 4c5299b9e..bbd1fb62d 100644 --- a/apps/emqx/src/emqx_ws_connection.erl +++ b/apps/emqx/src/emqx_ws_connection.erl @@ -646,7 +646,7 @@ serialize_and_inc_stats_fun(#state{serialize = Serialize}) -> ?SLOG(error, #{ input_packet => Packet , exception => Reason , stacktrace => Stacktrace}), - erlang:raise(error, Reason, Stacktrace) + erlang:error(frame_serialize_error) end end.