chore: address previous review comments

This commit is contained in:
Zaiming (Stone) Shi 2024-02-29 15:40:57 +01:00
parent 66fbcdcefa
commit 21cf600242
2 changed files with 5 additions and 2 deletions

View File

@ -32,7 +32,9 @@
-record(serde, { -record(serde, {
name :: schema_name(), name :: schema_name(),
type :: serde_type(), type :: serde_type(),
eval_context :: term() eval_context :: term(),
%% for future use
extra = []
}). }).
-type serde() :: #serde{}. -type serde() :: #serde{}.

View File

@ -312,8 +312,9 @@ ensure_serde_absent(Name) when not is_binary(Name) ->
ensure_serde_absent(Name) -> ensure_serde_absent(Name) ->
case get_serde(Name) of case get_serde(Name) of
{ok, Serde} -> {ok, Serde} ->
ok = emqx_schema_registry_serde:destroy(Serde),
_ = ets:delete(?SERDE_TAB, Name), _ = ets:delete(?SERDE_TAB, Name),
ok = emqx_schema_registry_serde:destroy(Serde); ok;
{error, not_found} -> {error, not_found} ->
ok ok
end. end.