yuanbiao
/
emqx
1
0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

chore(emqx_retainer): avoid race condition

This commit is contained in:
z8674558 2021-03-02 16:43:04 +09:00 committed by Yudai Kiyofuji
parent 70625b1942
commit 1f238f4c26
1 changed files with 12 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
apps/emqx_retainer/src/emqx_retainer.erl
View File

@ -205,14 +205,18 @@ store_retained(Msg = #message{topic = Topic, payload = Payload}, Env) ->
msg = Msg, msg = Msg,
expiry_time = get_expiry_time(Msg, Env)}); expiry_time = get_expiry_time(Msg, Env)});
{true, false} -> {true, false} ->
case mnesia:dirty_read(?TAB, Topic) of {atomic, _} = mnesia:transaction(
[_] -> fun() ->
mnesia:dirty_write(?TAB, #retained{topic = topic2tokens(Topic), case mnesia:read(?TAB, Topic) of
msg = Msg, [_] ->
expiry_time = get_expiry_time(Msg, Env)}); mnesia:write(?TAB, #retained{topic = topic2tokens(Topic),
[] -> msg = Msg,
?LOG(error, "Cannot retain message(topic=~s) for table is full!", [Topic]) expiry_time = get_expiry_time(Msg, Env)}, write);
end; [] ->
?LOG(error, "Cannot retain message(topic=~s) for table is full!", [Topic])
end
end),
ok;
{true, _} -> {true, _} ->
?LOG(error, "Cannot retain message(topic=~s) for table is full!", [Topic]); ?LOG(error, "Cannot retain message(topic=~s) for table is full!", [Topic]);
{_, true} -> {_, true} ->