Merge pull request #8855 from thalesmg/fix-dialyzer-v44-a

chore: fix dialyzer errors (v4.4)

.github/workflows/build_slim_packages.yaml

@@ -56,12 +56,7 @@ jobs:
     - name: make xref
       run: make xref
     - name: make dialyzer
-      run: |
-        # TODO: once dialyzer warnings are fixed in 4.4+, we may
-        # enforce this.
-        if [[ "$(./pkg-vsn.sh)" =~ 4.3.* ]]; then
-          make dialyzer
-        fi
+      run: make dialyzer
     - name: build zip packages
       run: make ${EMQX_NAME}-zip
     - name: build deb/rpm packages

apps/emqx_management/src/emqx_mgmt_api_pubsub.erl

@@ -121,8 +121,8 @@ loop_publish([Params | ParamsN], Acc) ->
         try parse_publish_params(Params) of
             Res ->
                 Code = case do_publish(Params, Res) of
-                           {ok, _} -> 0;
-                           {_, Code0, _} -> Code0
+                           {ok, #{code := ?SUCCESS}} -> 0;
+                           {ok, #{code := Code0}} -> Code0
                        end,
                 #{topic => resp_topic(proplists:get_value(<<"topic">>, Params),
                                       proplists:get_value(<<"topics">>, Params, <<"">>)),